[11.x] [HDRP] [bugfix 1292501] - Ensure all passes request the DiffusionProfile for SRP batcher compatibility #2790

Author: Chris Tchou

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed computation of geometric normal in path tracing (case 1293029).
 - Fixed issues with path-traced volumetric scattering (cases 1295222, 1295234).
 - Fixed issue with faulty shadow transition when view is close to an object under some aspect ratio conditions
+- Fixed issue where some ShaderGraph generated shaders were not SRP compatible because of UnityPerMaterial cbuffer layout mismatches [1292501] (https://issuetracker.unity3d.com/issues/a2-some-translucent-plus-alphaclipping-shadergraphs-are-not-srp-batcher-compatible)
 
 ### Changed
 - Now reflection probes cannot have SSAO, SSGI, SSR, ray tracing effects or volumetric reprojection.

com.unity.render-pipelines.high-definition/Editor/Material/ShaderGraph/HDShaderPasses.cs

@@ -539,25 +539,25 @@ public static PassDescriptor GenerateTransparentDepthPrepass(bool supportLightin
 
                 validPixelBlocks = supportLighting ?
                     new BlockFieldDescriptor[]
-                    {
-                        BlockFields.SurfaceDescription.Alpha,
-                        HDBlockFields.SurfaceDescription.AlphaClipThresholdDepthPrepass,
-                        BlockFields.SurfaceDescription.AlphaClipThreshold,
-                        HDBlockFields.SurfaceDescription.DepthOffset,
-                        BlockFields.SurfaceDescription.NormalTS,
-                        BlockFields.SurfaceDescription.NormalWS,
-                        BlockFields.SurfaceDescription.NormalOS,
-                        BlockFields.SurfaceDescription.Smoothness,
-                        HDBlockFields.SurfaceDescription.DiffusionProfileHash   // not used, but keeps the UnityPerMaterial cbuffer identical
-                    } :
-                    new BlockFieldDescriptor[]
-                    {
-                        BlockFields.SurfaceDescription.Alpha,
-                        HDBlockFields.SurfaceDescription.AlphaClipThresholdDepthPrepass,
-                        BlockFields.SurfaceDescription.AlphaClipThreshold,
-                        HDBlockFields.SurfaceDescription.DepthOffset,
-                        HDBlockFields.SurfaceDescription.DiffusionProfileHash   // not used, but keeps the UnityPerMaterial cbuffer identical
-                    },
+                {
+                    BlockFields.SurfaceDescription.Alpha,
+                    HDBlockFields.SurfaceDescription.AlphaClipThresholdDepthPrepass,
+                    BlockFields.SurfaceDescription.AlphaClipThreshold,
+                    HDBlockFields.SurfaceDescription.DepthOffset,
+                    BlockFields.SurfaceDescription.NormalTS,
+                    BlockFields.SurfaceDescription.NormalWS,
+                    BlockFields.SurfaceDescription.NormalOS,
+                    BlockFields.SurfaceDescription.Smoothness,
+                    HDBlockFields.SurfaceDescription.DiffusionProfileHash   // not used, but keeps the UnityPerMaterial cbuffer identical
+                } :
+                new BlockFieldDescriptor[]
+                {
+                    BlockFields.SurfaceDescription.Alpha,
+                    HDBlockFields.SurfaceDescription.AlphaClipThresholdDepthPrepass,
+                    BlockFields.SurfaceDescription.AlphaClipThreshold,
+                    HDBlockFields.SurfaceDescription.DepthOffset,
+                    HDBlockFields.SurfaceDescription.DiffusionProfileHash   // not used, but keeps the UnityPerMaterial cbuffer identical
+                },
 
                 // Collections
                 requiredFields = TransparentDepthPrepassFields,