[VFX] Fix URP compilation with SG (& fix warning) (#5187)

* Fix case 1349894

Issue with Lit Quad Output using ShaderGraph in URP

* Fix & Improve warning message about VFX

Fix sub issue from case 1343124

* *Update changelog.md

* Improve condition to correctly support URP & HDRP together

Author: PaulDemeulenaere

com.unity.render-pipelines.high-definition/Editor/Material/ShaderGraph/HDTarget.cs

@@ -366,15 +366,22 @@ public override bool WorksWithSRP(RenderPipelineAsset scriptableRenderPipeline)
             return scriptableRenderPipeline?.GetType() == typeof(HDRenderPipelineAsset);
         }
 
-        public bool SupportsVFX()
+        public bool CanSupportVFX()
         {
             if (m_ActiveSubTarget.value == null)
                 return false;
 
             if (m_IncompatibleVFXSubTargets.Contains(m_ActiveSubTarget.value.GetType()))
                 return false;
 
-            return m_SupportVFX;
+            return true;
+        }
+
+        public bool SupportsVFX()
+        {
+            if (CanSupportVFX())
+                return m_SupportVFX;
+            return false;
         }
 
         public void ConfigureContextData(VFXContext context, VFXContextCompiledData data)

com.unity.render-pipelines.universal/CHANGELOG.md

@@ -154,6 +154,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed issue with legacy stereo matrices with XR multipass. [case 1342416]
 - Fixed unlit shader function name ambiguity
 - Fixed Terrain holes not appearing in shadows [case 1349305]
+- VFX: Compilation issue with ShaderGraph and planar lit outputs [case 1349894](https://issuetracker.unity3d.com/product/unity/issues/guid/1349894/)
 
 ### Changed
 - Change Asset/Create/Shader/Universal Render Pipeline/Lit Shader Graph to Asset/Create/Shader Graph/URP/Lit Shader Graph

com.unity.render-pipelines.universal/Editor/VFXGraph/Shaders/Templates/ParticlePlanarPrimitivesLit/PassForward.template

@@ -104,7 +104,7 @@ ${VFXEnd}
             ${SHADERGRAPH_PIXEL_CALL_FORWARD}
 
             ${VFXIncludeRP("VFXSGSurfaceData.template")}
-            outColor = VFXGetPixelOutputForwardShaderGraph(i, surface, builtinEmissiveColor, builtinOpacity);
+            outColor = VFXGetPixelOutputForwardShaderGraph(i, surface, normalWS);
         #else
             outColor = VFXGetPixelOutputForward(i, normalWS, uvData);
         #endif

com.unity.shadergraph/CHANGELOG.md

@@ -126,6 +126,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed a ShaderGraph issue where Float properties in Integer mode would not be cast properly in graph previews [1330302](https://fogbugz.unity3d.com/f/cases/1330302/)
 - Fixed a ShaderGraph issue where hovering over a context block but not its node stack would not bring up the incorrect add menu [1351733](https://fogbugz.unity3d.com/f/cases/1351733/)
 - Fixed the BuiltIn Target to perform shader variant stripping [1345580] (https://issuetracker.unity3d.com/product/unity/issues/guid/1345580/)
+- Fixed incorrect warning while using VFXTarget
 
 ## [11.0.0] - 2020-10-21
 

com.unity.shadergraph/Editor/Data/Interfaces/IMaySupportVFX.cs

@@ -3,6 +3,7 @@ namespace UnityEditor.ShaderGraph
     public interface IMaySupportVFX
     {
         bool SupportsVFX();
+        bool CanSupportVFX();
     }
 
     static class MaySupportVFXExtensions
@@ -12,5 +13,11 @@ public static bool SupportsVFX(this Target target)
             var vfxTarget = target as IMaySupportVFX;
             return vfxTarget != null && vfxTarget.SupportsVFX();
         }
+
+        public static bool CanSupportVFX(this Target target)
+        {
+            var vfxTarget = target as IMaySupportVFX;
+            return vfxTarget != null && vfxTarget.CanSupportVFX();
+        }
     }
 }

com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/GraphDataPropertyDrawer.cs

@@ -112,13 +112,16 @@ void RegisterActionToUndo(string actionName)
 
 #if VFX_GRAPH_10_0_0_OR_NEWER
             // Inform the user that VFXTarget is deprecated, if they are using one.
-            if (graphData.m_ActiveTargets.Count(t => t.value.SupportsVFX()) == 1 &&
-                graphData.m_ActiveTargets.Count(t => t.value is VFXTarget) == 1)
+            var activeTargetSRP = graphData.m_ActiveTargets.Where(t => !(t.value is VFXTarget));
+            if (graphData.m_ActiveTargets.Any(t => t.value is VFXTarget) //Use Old VFXTarget
+                && activeTargetSRP.Any()
+                && activeTargetSRP.All(o => o.value.CanSupportVFX()))
             {
                 var vfxWarning = new HelpBoxRow(MessageType.Info);
 
-                var vfxWarningLabel = new Label("The Visual Effect target is deprecated. \n" +
-                    "Add a Universal or HDRP target instead, and enable 'Support VFX Graph' in the Graph Inspector.");
+                var vfxWarningLabel = new Label("The Visual Effect target is deprecated.\n" +
+                    "Use the SRP target(s) instead, and enable 'Support VFX Graph' in the Graph Inspector.\n" +
+                    "Then, you can remove the Visual Effect Target.");
 
                 vfxWarningLabel.style.color = new StyleColor(Color.white);
                 vfxWarningLabel.style.whiteSpace = WhiteSpace.Normal;

com.unity.shadergraph/Editor/Generation/Targets/VFXTarget.cs

@@ -145,6 +145,7 @@ public override bool WorksWithSRP(RenderPipelineAsset scriptableRenderPipeline)
         }
 
         public bool SupportsVFX() => true;
+        public bool CanSupportVFX() => true;
     }
 }
 #endif