Fix 1290493 - Spaceship specific warnings (#176)

* Avoid implicit trucation in template + safe normalize setting

* Update CHANGELOG.md

* Added variants

* Delete conditioning on GPU evaluation + conservative safe normalize

Co-authored-by: Julien Fryer <[email protected]>

Author: 2 people

com.unity.render-pipelines.high-definition/Editor/VFXGraph/Shaders/VFXLitVaryings.template

@@ -67,7 +67,7 @@ o.VFX_VARYING_METALLIC = metallic;
 #elif HDRP_MATERIAL_TYPE_SPECULAR
 #ifdef VFX_VARYING_SPECULAR
 ${VFXLoadParameter:{specularColor}}
-o.VFX_VARYING_SPECULAR = specularColor;
+o.VFX_VARYING_SPECULAR = specularColor.rgb;
 #endif
 #elif HDRP_MATERIAL_TYPE_TRANSLUCENT
 #ifdef VFX_VARYING_THICKNESS
@@ -92,7 +92,7 @@ o.VFX_VARYING_EMISSIVESCALE = emissiveScale;
 o.VFX_VARYING_EMISSIVE = attributes.color;
 #elif HDRP_USE_ADDITIONAL_EMISSIVE_COLOR
 ${VFXLoadParameter:{emissiveColor}}
-o.VFX_VARYING_EMISSIVE = emissiveColor;
+o.VFX_VARYING_EMISSIVE = emissiveColor.rgb;
 #endif
 #endif
 #if HDRP_USE_ADDITIONAL_BASE_COLOR

com.unity.visualeffectgraph/CHANGELOG.md

@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Exclude Operator, Context, Block and Subgraph from Preset [Case 1232309](https://issuetracker.unity3d.com/product/unity/issues/guid/1232309/)
 - Fix [Case 1212002](https://fogbugz.unity3d.com/f/cases/1212002/)
 - Fix [Case 1223747](https://fogbugz.unity3d.com/f/cases/1223747/)
+- Fix [Case 1290493](https://fogbugz.unity3d.com/f/cases/1290493/#BugEvent.1072735759)
 
 ## [10.2.0] - 2020-10-19
 ### Added

com.unity.visualeffectgraph/Editor/Models/Operators/Implementations/Normalize.cs

@@ -1,21 +1,44 @@
 using System;
+using System.Collections.Generic;
 using UnityEngine;
 
 namespace UnityEditor.VFX.Operator
 {
-    [VFXInfo(category = "Math/Vector")]
+    class SafeNormalizationVariantProvider : VariantProvider
+    {
+        protected override sealed Dictionary<string, object[]> variants
+        {
+            get
+            {
+                return new Dictionary<string, object[]>
+                {
+                    { "safeNormalize", new object[]{true, false} }
+                };
+            }
+        }
+    }
+
+
+    [VFXInfo(category = "Math/Vector", variantProvider = typeof(SafeNormalizationVariantProvider))]
     class Normalize : VFXOperatorNumericUniform
     {
         public class InputProperties
         {
             public Vector3 x = Vector3.one;
         }
 
-        protected override sealed string operatorName { get { return "Normalize"; } }
+        [VFXSetting(VFXSettingAttribute.VisibleFlags.InInspector), SerializeField, Tooltip("Specifies if the operator should check if the vector to be normalized is a vero vector.")]
+        bool safeNormalize = false;
+
+
+        protected override sealed string operatorName { get {return  safeNormalize ?  "Safe Normalize" :  "Normalize"; } }
 
         protected override sealed VFXExpression[] BuildExpression(VFXExpression[] inputExpression)
         {
-            return new[] { VFXOperatorUtility.Normalize(inputExpression[0]) };
+            if(safeNormalize)
+                return new[] { VFXOperatorUtility.SafeNormalize(inputExpression[0]) };
+            else
+                return new[] { VFXOperatorUtility.Normalize(inputExpression[0]) };
         }
 
         protected override sealed ValidTypeRule typeFilter

com.unity.visualeffectgraph/Editor/Models/Operators/VFXOperatorUtility.cs

@@ -33,6 +33,8 @@ public static Dictionary<VFXValueType, VFXExpression> GenerateExpressionConstant
         public static readonly Dictionary<VFXValueType, VFXExpression> TauExpression = GenerateExpressionConstant(2.0f * Mathf.PI);
         public static readonly Dictionary<VFXValueType, VFXExpression> E_NapierConstantExpression = GenerateExpressionConstant(Mathf.Exp(1));
         public static readonly Dictionary<VFXValueType, VFXExpression> EpsilonExpression = GenerateExpressionConstant(1e-5f);
+        public static readonly Dictionary<VFXValueType, VFXExpression> EpsilonSqrExpression = GenerateExpressionConstant(1e-10f);
+
 
         public enum Base
         {
@@ -269,7 +271,7 @@ static public VFXExpression Normalize(VFXExpression v)
         static public VFXExpression SafeNormalize(VFXExpression v)
         {
             var sqrDist = Dot(v, v);
-            var condition = new VFXExpressionCondition(VFXValueType.Float, VFXCondition.Equal, VFXOperatorUtility.ZeroExpression[VFXValueType.Float], sqrDist);
+            var condition = new VFXExpressionCondition(VFXValueType.Float, VFXCondition.Less, VFXOperatorUtility.EpsilonSqrExpression[VFXValueType.Float], sqrDist);
             return new VFXExpressionBranch(condition, VFXOperatorUtility.ZeroExpression[v.valueType], Normalize(v));
         }