Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. (#1529)

* Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile.

* Update changelog

Author: JulienIgnace-Unity

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -781,6 +781,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed issues that lead to cookie atlas to be updated every frame even if cached data was valid.
 - Fixed an issue where world space UI was not emitted for reflection cameras in HDRP
 - Fixed an issue with cookie texture atlas that would cause realtime textures to always update in the atlas even when the content did not change.
+- Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile.
 
 ### Changed
 - Improve MIP selection for decals on Transparents

com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LookDev.cs

@@ -5,32 +5,29 @@ namespace UnityEngine.Rendering.HighDefinition
 {
     public partial class HDRenderPipeline : IDataProvider
     {
-#if UNITY_EDITOR
-        int m_LookDevVolumeProfileHash = -1;
-#endif
-
         struct LookDevDataForHDRP
         {
             public HDAdditionalCameraData additionalCameraData;
             public HDAdditionalLightData additionalLightData;
             public VisualEnvironment visualEnvironment;
             public HDRISky sky;
             public Volume volume;
+            public int currentVolumeProfileHash;
         }
 
 #if UNITY_EDITOR
-        bool UpdateVolumeProfile(Volume volume, out VisualEnvironment visualEnvironment, out HDRISky sky)
+        bool UpdateVolumeProfile(Volume volume, out VisualEnvironment visualEnvironment, out HDRISky sky, ref int volumeProfileHash)
         {
             HDRenderPipelineAsset hdrpAsset = GraphicsSettings.renderPipelineAsset as HDRenderPipelineAsset;
             if (hdrpAsset.defaultLookDevProfile == null)
                 hdrpAsset.defaultLookDevProfile = hdrpAsset.renderPipelineEditorResources.lookDev.defaultLookDevVolumeProfile;
 
             int newHashCode = hdrpAsset.defaultLookDevProfile.GetHashCode();
-            if (newHashCode != m_LookDevVolumeProfileHash)
+            if (newHashCode != volumeProfileHash)
             {
                 VolumeProfile oldProfile = volume.sharedProfile;
 
-                m_LookDevVolumeProfileHash = newHashCode;
+                volumeProfileHash = newHashCode;
 
                 VolumeProfile profile = ScriptableObject.Instantiate(hdrpAsset.defaultLookDevProfile);
                 profile.hideFlags = HideFlags.HideAndDontSave;
@@ -118,16 +115,17 @@ void IDataProvider.FirstInitScene(StageRuntimeInterface SRI)
 
 #if UNITY_EDITOR
             // Make sure we invalidate the current volume when first loading a scene.
-            m_LookDevVolumeProfileHash = -1;
-            UpdateVolumeProfile(volume, out var visualEnvironment, out var sky);
+            int volumeProfileHash = -1;
+            UpdateVolumeProfile(volume, out var visualEnvironment, out var sky, ref volumeProfileHash);
 
             SRI.SRPData = new LookDevDataForHDRP()
             {
                 additionalCameraData = additionalCameraData,
                 additionalLightData = additionalLightData,
                 visualEnvironment = visualEnvironment,
                 sky = sky,
-                volume = volume
+                volume = volume,
+                currentVolumeProfileHash = volumeProfileHash
             };
 #else
             //remove unassigned warnings when building
@@ -174,11 +172,13 @@ void IDataProvider.OnBeginRendering(StageRuntimeInterface SRI)
         {
             LookDevDataForHDRP data = (LookDevDataForHDRP)SRI.SRPData;
 #if UNITY_EDITOR
+            int currentHash = data.currentVolumeProfileHash;
             // The default volume can change in the HDRP asset so if it does we need to re-instantiate it.
-            if (UpdateVolumeProfile(data.volume, out var visualEnv, out var sky))
+            if (UpdateVolumeProfile(data.volume, out var visualEnv, out var sky, ref currentHash))
             {
                 data.sky = sky;
                 data.visualEnvironment = visualEnv;
+                data.currentVolumeProfileHash = currentHash;
                 SRI.SRPData = data;
             }
 #endif