Fixed an issue where forced sky update would not update ambient probe. #6831

Author: JulienIgnace-Unity

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471).
 - Fixed missing unit in ray tracing related tooltips and docs (case 1397491).
 - Fixed artifacts on gpu light culling when the frustum near and far are very spread out (case 1386436)
+- Fixed an issue where forced sky update (like PBR sky amortized updated) would not update ambient probe.
 
 ## [12.1.4] - 2021-12-07
 

com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs

@@ -884,15 +884,14 @@ public void UpdateEnvironment(HDCamera hdCamera,
                             // Debug.Log("Update Sky Lighting");
                             RenderSkyToCubemap(skyContext);
 
-                            if (updateAmbientProbe && !renderingContext.computeAmbientProbeRequested)
+                            if (updateAmbientProbe)
                             {
                                 using (new ProfilingScope(cmd, ProfilingSampler.Get(HDProfileId.UpdateSkyAmbientProbe)))
                                 {
                                     cmd.SetComputeBufferParam(m_ComputeAmbientProbeCS, m_ComputeAmbientProbeKernel, m_AmbientProbeOutputBufferParam, renderingContext.ambientProbeResult);
                                     cmd.SetComputeTextureParam(m_ComputeAmbientProbeCS, m_ComputeAmbientProbeKernel, m_AmbientProbeInputCubemap, renderingContext.skyboxCubemapRT);
                                     cmd.DispatchCompute(m_ComputeAmbientProbeCS, m_ComputeAmbientProbeKernel, 1, 1, 1);
                                     cmd.RequestAsyncReadback(renderingContext.ambientProbeResult, renderingContext.OnComputeAmbientProbeDone);
-                                    renderingContext.computeAmbientProbeRequested = true;
 
                                     // When the profiler is enabled, we don't want to submit the render context because
                                     // it will break all the profiling sample Begin() calls issued previously, which leads

com.unity.render-pipelines.high-definition/Runtime/Sky/SkyRenderingContext.cs

@@ -15,7 +15,6 @@ internal class SkyRenderingContext
         public bool supportsConvolution { get; private set; } = false;
 
         internal bool ambientProbeIsReady = false;
-        public bool computeAmbientProbeRequested = false;
 
         public SkyRenderingContext(int resolution, int bsdfCount, bool supportsConvolution, SphericalHarmonicsL2 ambientProbe, string name)
         {
@@ -44,7 +43,6 @@ public SkyRenderingContext(int resolution, int bsdfCount, bool supportsConvoluti
         public void Reset()
         {
             ambientProbeIsReady = false;
-            computeAmbientProbeRequested = false;
         }
 
         public void Cleanup()