dont skip if shadow update mode is on demand (#81)

Paulm-Unity · Deployer User · commit 23cc429114e2 · 2022-05-16T23:52:20.000Z
diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDProcessedVisibleLightsBuilder.LightLoop.cs b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDProcessedVisibleLightsBuilder.LightLoop.cs
@@ -116,16 +116,18 @@ private void ProcessShadows(
                     {
                         int lightIndex = m_ShadowLightsDataIndices[i];
                         HDProcessedVisibleLight* entity = entitiesPtr + lightIndex;
-                        if (!cullResults.GetShadowCasterBounds(lightIndex, out var bounds) || defaultEntityDataIndex == entity->dataIndex)
+                        HDAdditionalLightData additionalLightData = HDLightRenderDatabase.instance.hdAdditionalLightData[entity->dataIndex];
+
+                        if (additionalLightData == null)
+                            continue;
+
+                        if ((!cullResults.GetShadowCasterBounds(lightIndex, out var bounds) && additionalLightData.shadowUpdateMode != ShadowUpdateMode.OnDemand) || defaultEntityDataIndex == entity->dataIndex)
                         {
                             entity->shadowMapFlags = ShadowMapFlags.None;
                             continue;
                         }
 
-                        HDAdditionalLightData additionalLightData = HDLightRenderDatabase.instance.hdAdditionalLightData[entity->dataIndex];
-                        if (additionalLightData == null)
-                            continue;
-
+                        
                         VisibleLight visibleLight = visibleLights[lightIndex];
                         additionalLightData.ReserveShadowMap(hdCamera.camera, shadowManager, hdShadowSettings, inShadowInitParameters, visibleLight, entity->lightType);
                     }

Original file line number	Diff line number	Diff line change
`@@ -116,16 +116,18 @@ private void ProcessShadows(`
`116`	`116`	`{`
`117`	`117`	`int lightIndex = m_ShadowLightsDataIndices[i];`
`118`	`118`	`HDProcessedVisibleLight* entity = entitiesPtr + lightIndex;`
`119`		`- if (!cullResults.GetShadowCasterBounds(lightIndex, out var bounds) \|\| defaultEntityDataIndex == entity->dataIndex)`
	`119`	`+ HDAdditionalLightData additionalLightData = HDLightRenderDatabase.instance.hdAdditionalLightData[entity->dataIndex];`
	`120`	`+`
	`121`	`+ if (additionalLightData == null)`
	`122`	`+ continue;`
	`123`	`+`
	`124`	`+ if ((!cullResults.GetShadowCasterBounds(lightIndex, out var bounds) && additionalLightData.shadowUpdateMode != ShadowUpdateMode.OnDemand) \|\| defaultEntityDataIndex == entity->dataIndex)`
`120`	`125`	`{`
`121`	`126`	`entity->shadowMapFlags = ShadowMapFlags.None;`
`122`	`127`	`continue;`
`123`	`128`	`}`
`124`	`129`
`125`		`- HDAdditionalLightData additionalLightData = HDLightRenderDatabase.instance.hdAdditionalLightData[entity->dataIndex];`
`126`		`- if (additionalLightData == null)`
`127`		`- continue;`
`128`		`-`
	`130`	`+`
`129`	`131`	`VisibleLight visibleLight = visibleLights[lightIndex];`
`130`	`132`	`additionalLightData.ReserveShadowMap(hdCamera.camera, shadowManager, hdShadowSettings, inShadowInitParameters, visibleLight, entity->lightType);`
`131`	`133`	`}`