[HDRP] Fix static sky lighting update when render textures are updated #6863

Author: Antoine Lelievre

com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs

@@ -1447,6 +1447,19 @@ public TextureParameter(Texture value, bool overrideState = false)
             : base(value, overrideState) { }
 
         // TODO: Texture interpolation
+
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>
@@ -1462,6 +1475,19 @@ public class NoInterpTextureParameter : VolumeParameter<Texture>
         /// <param name="overrideState">The initial override state for the parameter.</param>
         public NoInterpTextureParameter(Texture value, bool overrideState = false)
             : base(value, overrideState) { }
+
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>
@@ -1477,6 +1503,19 @@ public class Texture2DParameter : VolumeParameter<Texture>
         /// <param name="overrideState">The initial override state for the parameter.</param>
         public Texture2DParameter(Texture value, bool overrideState = false)
             : base(value, overrideState) { }
+
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>
@@ -1492,6 +1531,19 @@ public class Texture3DParameter : VolumeParameter<Texture>
         /// <param name="overrideState">The initial override state for the parameter.</param>
         public Texture3DParameter(Texture value, bool overrideState = false)
             : base(value, overrideState) { }
+
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>
@@ -1509,6 +1561,19 @@ public RenderTextureParameter(RenderTexture value, bool overrideState = false)
             : base(value, overrideState) { }
 
         // TODO: RenderTexture interpolation
+
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>
@@ -1524,6 +1589,19 @@ public class NoInterpRenderTextureParameter : VolumeParameter<RenderTexture>
         /// <param name="overrideState">The initial override state for the parameter.</param>
         public NoInterpRenderTextureParameter(RenderTexture value, bool overrideState = false)
             : base(value, overrideState) { }
+
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>
@@ -1540,6 +1618,19 @@ public class CubemapParameter : VolumeParameter<Texture>
         public CubemapParameter(Texture value, bool overrideState = false)
             : base(value, overrideState) { }
         // TODO: Cubemap interpolation
+
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>
@@ -1555,6 +1646,19 @@ public class NoInterpCubemapParameter : VolumeParameter<Cubemap>
         /// <param name="overrideState">The initial override state for the parameter.</param>
         public NoInterpCubemapParameter(Cubemap value, bool overrideState = false)
             : base(value, overrideState) { }
+    
+        public override int GetHashCode()
+        {
+            int hash = base.GetHashCode();
+
+            unchecked
+            {
+                if (value != null)
+                    hash = 23 * CoreUtils.GetTextureHash(value);
+            }
+            
+            return hash;
+        }
     }
 
     /// <summary>

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed artifacts on gpu light culling when the frustum near and far are very spread out (case 1386436)
 - Fixed an issue where forced sky update (like PBR sky amortized updated) would not update ambient probe.
 - Fixed a null ref exception in Volume Explorer
+- Fixed static lighting sky update when using an HDRI sky with a render texture in parameter.
 
 ## [12.1.4] - 2021-12-07
 

com.unity.render-pipelines.high-definition/Runtime/Sky/HDRISky/HDRISky.cs

@@ -150,8 +150,8 @@ public override int GetHashCode()
                 hash = hash * 23 + dirLightShadow.overrideState.GetHashCode();
                 hash = hash * 23 + rectLightShadow.overrideState.GetHashCode();
 #else
-                hash = hdriSky.value != null ? hash * 23 + hdriSky.GetHashCode() : hash;
-                hash = flowmap.value != null ? hash * 23 + flowmap.GetHashCode() : hash;
+                hash = hash * 23 + hdriSky.GetHashCode();
+                hash = hash * 23 + flowmap.GetHashCode();
                 hash = hash * 23 + distortionMode.GetHashCode();
                 hash = hash * 23 + upperHemisphereOnly.GetHashCode();
                 hash = hash * 23 + scrollOrientation.GetHashCode();