Some extra security around error feedback (#153)

* Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui

* Prevent list from being badly deserialized.

Author: iTris666

com.unity.visualeffectgraph/Editor/GraphView/Views/Controller/VFXViewController.cs

@@ -205,7 +205,14 @@ public void NotifyUpdate()
                         while (m_CurrentActions.Count > 0)
                         {
                             var action = m_CurrentActions[m_CurrentActions.Count - 1];
-                            action();
+                            try
+                            {
+                                action();
+                            }
+                            catch(Exception e)
+                            {
+                                Debug.LogException(e);
+                            }
                             cpt++;
                             m_CurrentActions.RemoveAt(m_CurrentActions.Count - 1);
                         }

com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs

@@ -580,7 +580,10 @@ DropdownMenuAction.Status ShaderValidationStatus(DropdownMenuAction action)
                 return DropdownMenuAction.Status.Normal;
         }
 
+        [NonSerialized]
         Dictionary<VFXModel, List<IconBadge>> m_InvalidateBadges = new Dictionary<VFXModel, List<IconBadge>>();
+
+        [NonSerialized]
         List<IconBadge> m_CompileBadges = new List<IconBadge>();
 
         private void RegisterError(VFXModel model, VFXErrorOrigin errorOrigin,string error,VFXErrorType type, string description)

com.unity.visualeffectgraph/Editor/Models/VFXModel.cs

@@ -133,7 +133,14 @@ public void RefreshErrors(VFXGraph graph)
                 graph.errorManager.ClearAllErrors(this, VFXErrorOrigin.Invalidate);
                 using (var reporter = new VFXInvalidateErrorReporter(graph.errorManager, this))
                 {
-                    GenerateErrors(reporter);
+                    try
+                    {
+                        GenerateErrors(reporter);
+                    }
+                    catch(Exception e)
+                    {
+                        Debug.LogException(e);
+                    }
                 }
             }
         }