Fix missing depth on overlay camera DoF (#6549)

* Metal HDRP ref screenshots update (#6507)

* Fix typo in comment.

* Fix overlay depth.

* Add test case.

* Fix missing depth for overlay DoF. Workaround MacOS depth as wireframe driver bug.

URPasset has a depth texture checkbox, but that fixes the depth issue as well, but it's meant to be manual "force include depth" for case that can't be autodetected.
This one is correctly detected, but hardcode to not include depth (which is removed in this commit).

* Revert bug workaround. It's in another PR.

* Revert "Add test case."

This reverts commit c2e3067.

* Edit changelog.

Co-authored-by: sebastienlagarde <[email protected]>
Co-authored-by: Felipe Lira <[email protected]>

Author: 3 people

TestProjects/HDRP_RuntimeTests/Assets/ReferenceImages/Linear/OSXPlayer/Metal/None/004-CloudsFlaresDecals.png

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed inspector documentation URLs for the URP asset and Universal Renderer asset.
 - Fixed render scale setting unintentionally affecting the scene view camera.
 - Fixed property wrappers around material properties.
+- Fixed missing depth for Depth of Field in an overlay camera. [case 1365623](https://issuetracker.unity3d.com/product/unity/issues/guid/1365623/)
 - Fixed FXAA quality issues when render scale is not 1.0.
 
 ## [13.1.2] - 2021-11-05

TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/1705_Decals-stress-test.png

@@ -940,7 +940,6 @@ static void InitializeAdditionalCameraData(Camera camera, UniversalAdditionalCam
             if (isOverlayCamera)
             {
                 cameraData.requiresOpaqueTexture = false;
-                cameraData.postProcessingRequiresDepthTexture = false;
             }
 
             Matrix4x4 projectionMatrix = camera.projectionMatrix;
@@ -990,7 +989,7 @@ static void InitializeRenderingData(UniversalRenderPipelineAsset settings, ref C
                 mainLightCastShadows = (mainLightIndex != -1 && visibleLights[mainLightIndex].light != null &&
                     visibleLights[mainLightIndex].light.shadows != LightShadows.None);
 
-                // If additional lights are shaded per-pixel they cannot cast shadows
+                // If additional lights are shaded per-vertex they cannot cast shadows
                 if (settings.additionalLightsRenderingMode == LightRenderingMode.PerPixel)
                 {
                     for (int i = 0; i < visibleLights.Length; ++i)