Partner/crazyhunter 10.7.0 custom.1 bursted shadowrequests (#97)

* Remove temp allocation and clamp array ranges

* Added two missing Dispose calls

Author: AdamStrickUnity

com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDGpuLightsBuilder.LightLoop.cs

@@ -397,7 +397,7 @@ private unsafe void CalculateAllLightDataTextureInfo(
 
             int directionalLightCount = visibleLights.sortedDirectionalLightCounts;
             int lightCounts = visibleLights.sortedLightCounts;
-            NativeArray<int> shadowIndices = new NativeArray<int>(lightCounts, Allocator.Temp);
+            NativeArray<int> shadowIndices = lightEntities.GetShadowIndicesScratchpadArray(lightCounts);
             HDAdditionalLightData.CalculateShadowIndices(hdCamera, in cullResults, visibleLights, lightEntities, hdShadowSettings, debugDisplaySettings,
                 m_ShadowManager, m_Asset, shadowIndices, ref m_DebugSelectedLightShadowIndex, ref m_DebugSelectedLightShadowCount);
 
@@ -486,8 +486,6 @@ private unsafe void CalculateAllLightDataTextureInfo(
                     }
                 }
             }
-
-            shadowIndices.Dispose();
         }
     }
 }

com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDLightRenderDatabase.cs

@@ -356,6 +356,22 @@ internal NativeBitArray GetValidIndexScratchpadArray(int minLightCount)
             return m_IsValidIndexScratchpadArray;
         }
 
+        internal NativeArray<int> GetShadowIndicesScratchpadArray(int minLightCount)
+        {
+            if (m_ShadowIndicesScratchpadArray.IsCreated && m_ShadowIndicesScratchpadArray.Length < minLightCount)
+            {
+                m_ShadowIndicesScratchpadArray.Dispose();
+                m_ShadowIndicesScratchpadArray = default;
+            }
+
+            if (!m_ShadowIndicesScratchpadArray.IsCreated)
+            {
+                m_ShadowIndicesScratchpadArray = new NativeArray<int>(minLightCount, Allocator.Persistent);
+            }
+
+            return m_ShadowIndicesScratchpadArray.GetSubArray(0, minLightCount);
+        }
+
 #if UNITY_EDITOR
         internal NativeArray<int> GetShadowRequestCountsScratchpad(int requestCount)
         {
@@ -370,7 +386,7 @@ internal NativeArray<int> GetShadowRequestCountsScratchpad(int requestCount)
                 m_ShadowRequestCountsScratchpad = new NativeArray<int>(requestCount, Allocator.Persistent);
             }
 
-            return m_ShadowRequestCountsScratchpad;
+            return m_ShadowRequestCountsScratchpad.GetSubArray(0, requestCount);
         }
 #endif
 
@@ -596,6 +612,7 @@ internal struct LightEntityInfo
         private NativeList<ShadowIndicesAndVisibleLightData> m_VisibleLightsAndIndicesBuffer = new NativeList<ShadowIndicesAndVisibleLightData>(Allocator.Persistent);
         private NativeList<ShadowIndicesAndVisibleLightData> m_SplitVisibleLightsAndIndicesBuffer = new NativeList<ShadowIndicesAndVisibleLightData>(Allocator.Persistent);
         private NativeBitArray m_IsValidIndexScratchpadArray = new NativeBitArray(256, Allocator.Persistent);
+        private NativeArray<int> m_ShadowIndicesScratchpadArray;
 #if UNITY_EDITOR
         NativeArray<int> m_ShadowRequestCountsScratchpad;
 #endif
@@ -655,6 +672,26 @@ private void RemoveAtSwapBackArrays(int removeIndexAt)
 
         private void DeleteArrays()
         {
+            if (m_IsValidIndexScratchpadArray.IsCreated)
+            {
+                m_IsValidIndexScratchpadArray.Dispose();
+                m_IsValidIndexScratchpadArray = default;
+            }
+
+            if (m_ShadowIndicesScratchpadArray.IsCreated)
+            {
+                m_ShadowIndicesScratchpadArray.Dispose();
+                m_ShadowIndicesScratchpadArray = default;
+            }
+
+
+#if UNITY_EDITOR
+            if (m_ShadowRequestCountsScratchpad.IsCreated)
+            {
+                m_ShadowRequestCountsScratchpad.Dispose();
+                m_ShadowRequestCountsScratchpad = default;
+            }
+#endif
             if (m_Capacity == 0)
                 return;
 
@@ -680,25 +717,13 @@ private void DeleteArrays()
             m_VisibleLightsAndIndicesBuffer = default;
             m_SplitVisibleLightsAndIndicesBuffer.Dispose();
             m_SplitVisibleLightsAndIndicesBuffer = default;
-            if (m_IsValidIndexScratchpadArray.IsCreated)
-            {
-                m_IsValidIndexScratchpadArray.Dispose();
-                m_IsValidIndexScratchpadArray = default;
-            }
-
-
-#if UNITY_EDITOR
-            if (m_ShadowRequestCountsScratchpad.IsCreated)
-            {
-                m_ShadowRequestCountsScratchpad.Dispose();
-                m_ShadowRequestCountsScratchpad = default;
-            }
-#endif
 
             m_HDShadowRequestStorage.Dispose();
             m_HDShadowRequestStorage = default;
             m_HDShadowRequestIndicesStorage.Dispose();
             m_HDShadowRequestIndicesStorage = default;
+            m_CachedViewPositionsStorage.Dispose();
+            m_CachedViewPositionsStorage = default;
             m_FrustumPlanesStorage.Dispose();
             m_FrustumPlanesStorage = default;
             m_HDShadowRequestsCreated = false;

com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDCachedShadowAtlas.cs

@@ -860,6 +860,8 @@ public override void Dispose()
                 m_RegisteredLightDataPendingPlacement = default;
                 m_RecordsPendingPlacement.Dispose();
                 m_RecordsPendingPlacement = default;
+                m_TransformCaches.Dispose();
+                m_TransformCaches = default;
             }
         }