[Hdrp] Merge Hd/bugfix (#6954)

* [HDRP] Fix AxF debug output in certain configurations (#4641)

* Fix AxF debug output in certain configurations.

* Update comment

* Fix SSR accumulation white flash (#4648)

* Fix white flash

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Display Info Box when MSAA + ray tracing is onr (#4627)

* Show info box when ray tracing is enabled.

* Changelog

* Move below MSAA

Co-authored-by: sebastienlagarde <[email protected]>

* Fix distortion when resizing the window in player builds with the Graphics Compositor enabled (#4593)

Co-authored-by: sebastienlagarde <[email protected]>

* Add support for the camera bridge in the graphics compositor (#4599)

* Fix Jittered Project Matrix Infinite Far Clip Plane  (#4638)

* Reconstruct jittered projection matrix far plane (for Infinite )

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed a memory leak related to not disposing of the RTAS at the end HDRP's lifecycle. (#4688)

Co-authored-by: sebastienlagarde <[email protected]>

* Fix custom pass utils Blur + Copy overdraw. (#4623)

* Fix overdraw in custom pass utils blur function

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix draw procedural invalid pass idx 1 on first template load (#4632)

* Fix

* changelog

* Force sync compilation for TAA

Co-authored-by: CifaCia <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>

* Changed light reset to preserve type (#4624)

Co-authored-by: sebastienlagarde <[email protected]>

* Revert "Add support for the camera bridge in the graphics compositor (#4599)"

This reverts commit 2325e3f.

* AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc side is updated. (case 1335737, related to 1314040) (#4691)

Co-authored-by: sebastienlagarde <[email protected]>

* Revert "Revert "Add support for the camera bridge in the graphics compositor (#4599)""

This reverts commit 30fffd5.

* revert: Fix distortion when resizing the window in player builds with the Graphi

* Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). (#4626)

* Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904).

* Add test scene

Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: Sebastien Lagarde <[email protected]>

* Fix for discrepancies in saturation and intensity between screen space refraction and probe refraction (#4653)

* Delete the second transmittance mul

* Changelog

Co-authored-by: Sebastien Lagarde <[email protected]>

* Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (#4636)

* Initialize the shading normal to a non-zero value for anisotropy

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix VfX lit particle AOV output color space (#4646)

* Fix VfX lit particle aov output color space

* Update comment

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP][Path Tracing] Fixed transparent unlit (#4605)

* Fixed issue with transparent unlit.

* Updated changelog.

* Reverted accidental change to default mtl.

Co-authored-by: sebastienlagarde <[email protected]>

* Fix distortion with MSAA (#4711)

* Fix contact shadow debug views (#4720)

* Fix

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Update Decal-Projector.md (#4695)

* [HDRP] Fixed nullref when deleting the texture asset assigned in a local volumetric fog volume (#4728)

* Fixed nullref when deleting the 3D mask of a density volume (case 1339330)

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix decal layer enum (#4753)

* Fix typo

* Fixed reflection probes being injected into the ray tracing light cluster even if not baked (case 1329083). (#4640)

Co-authored-by: sebastienlagarde <[email protected]>

* Ignore hybrid duplicated reflection probes during light baking (#4663)

* Ignore hybrid duplicated reflection probes during light baking

* test path instead of scene

Co-authored-by: sebastienlagarde <[email protected]>

* Fix double sided option moving when toggling it in the material UI (#4725)

* Fix double sided option moving when toggling it in the material UI (case 1328877)

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix formatting

* Fix volumetric fog in planar reflections (#4736)

* Fix planar reflection

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix motion blur compute dispatch size (#4737)

Co-authored-by: sebastienlagarde <[email protected]>

* - Updated the recursive rendering documentation (case 1338639). (#4759)

* - Updated the recursive rendering documentation (case 1338639).

* review fixes

Co-authored-by: sebastienlagarde <[email protected]>

* Fix issue with OnDemand directional shadow map being corrupted when reflection probe are updated same frame (#4812)

* Don't mark as rendered for reflection probes as we want the cached version to be from main view

* Do the thing just for directional

* Doc update

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix cropping issue with the compositor camera bridge (#4802)

Co-authored-by: sebastienlagarde <[email protected]>

* Fix for unused resources in depth of field (#4796)

* Removing the word Radii from exposure settings (#4854)

* Rename in UX

* Update docs

* [HDRP][Path Tracing] Support for shadow mattes (#4745)

* Shadow matte support.

* Updated changelog.

* Only take occluders into account, closer match to raster mode.

* Added test scene.

Co-authored-by: sebastienlagarde <[email protected]>

* Revert "[HDRP][Path Tracing] Support for shadow mattes (#4745)"

This reverts commit 85ebbc2.

* Fixed the transparent cutoff not working properly in semi-transparent  and color shadows (case 1340234). (#4756)

* Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234).

* Update test ref image

Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>

* Use non jittered projection in outline pass (#4836)

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP][Path Tracing] Sky settings now properly taken into account when using recorder (#4856)

* Make sure sky settings are correctly set when recording.

* Updated changelog.

Co-authored-by: sebastienlagarde <[email protected]>

* Fix Resolution Issues for Physically Based Depth of Field (#4848)

* Add the necesarry texture coordinate clamping for RTHandle for color pyramid sampling

* Add some resolution independence, fitted for 1920x1080

* Changelog

* Switch back to point sampling from trilinear, with commentary

* Update test reference images

* Small correction to the point sampling, always sample mip 0.

* Re-update the test images, for mip 0 color sampling

* Use a simpler UV scaling/clamping since we are now point sampling.

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed bug introduced by sky-for-recorder support. (#4906)

* [Fogbugz 1341576] Memory leaks when the player is paused, and the user changes pipeline… (#4845)

* Memory leaks when the player is paused, and the user changes pipeline settings

* changelog

* [HDRP] Fixed shadergraph double save (#4916)

* Don't need to save twice shadergraph the first time we create a graph

* Updated changelog

* Write 0 instead of micro sized motion vectors + fix extremely fast velocities (#4820)

* Kill micromovements.

* Do same for camera

* Debug view update

* Changelog

* Remove unnecessary comment

* Fix excessive velocity end up marked as no velocity

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix material upgrader (#4821)

* Fix HDRP material upgrade failing when there is a texture inside the builtin resources assigned in the material

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix custom pass volume not executed in scene view (#4860)

* Fix custom pass volume not executed in scene view because of the volume culling mask

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix reflection probe tootltip (#4890)

Co-authored-by: sebastienlagarde <[email protected]>

* Updated the Physically Based Sky documentation for baked lights (#4891)

* Updated the Physically Based Sky documentation for baked lights

* Rewrite

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed remapping of depth pyramid debug (#4893)

* Fixed remapping of depth pyramid debug

* Removed debug pragma

* Update changelog

* Updated tooltip

* Fix wobble-like (or tearing-like) SSAO issues when temporal reprojection is enabled. (#4895)

* Fix AO perceived wobble

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix Asymmetric Projection Matrices and Fog / Pathtracing (#4926)

* Check for asymmetric projections and choose the generic path if so.

* Fix asymmetric projections for the pathtracer ray generation.

* Changelog

* Simplify the matrix multiplication for computing the generic matrix.

Co-authored-by: sebastienlagarde <[email protected]>

* Revert: Fix wobble-like (or tearing-like) SSAO issues when temporal reprojection…

* Fix GBuffer depth debug mode (#5054)

* Fixed Volume Gizmo size when rescaling parent GameObject (#4915)

* Fix Vertex Color Mode documentation (#4976)

* Fix wobble-like (or tearing-like) SSAO issues when temporal reprojection is enabled.  (#4986)

* Fix AO perceived wobble

* changelog

* Update screenshots

Co-authored-by: sebastienlagarde <[email protected]>

* Fix formatting in NestedOverrideCameraRendering

* [HDRP] Fix white flash with SSR when resetting camera history (#5089)

* Fix white flash with SSR when resetting camera history

* Move branch login inside GetPreviousExposureTexture

* Fix for fixed exposure

* [Fobguz # 1348357] VFX Particle templates missing stencil flags (#5080)

* Adding missing macro for stencil flags in particle forward shaders. This will let flags like TAA Reject be useful

* Changelog

* Fix object disappearing from lookdev (#5063)

* Fixed objects disappearing from Lookdev window when entering playmode (case 1309368).

* Updated changelog

* Added hideflags in Lookdev context

* [HDRP] Fix render object after taa jittering (#5088)

* Add a pass after TAA to restore non jittered matrices

* updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix GC alloc in hd/bugfix branch (#5134)

* Fixed GC alloc on hd/bugfix branch

* Fix GC alloc again

* Fix refraction tile artifacts near reflection probe edges (#4727)

* Pick the right probe at object center instead of tile granularity.

* changelog

* Missing commit

* Move stuff in lightloop and out of prelightData

* Update LightLoop.hlsl

* Formatting

Co-authored-by: sebastienlagarde <[email protected]>

* Fix camera rotation uncontrollable with low framerate (#5076)

* Fix camera rotation uncontrollable with low framerate.

* updated changelog

* Clearing out render targets and randmo write targets on pipeline destruction (#5176)

Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed a null ref exception when adding a new environment to the library. (#5131)

* Fixed a null ref exception when adding a new environment to the library.

* Update changelog

Co-authored-by: sebastienlagarde <[email protected]>

* FogBugz#1348462 - Wait for accessing the HDProjectSettings instance as it was before. (#5141)

* Fix nullref in volume system after deleting a volume object (#5161)

* Fix nullref in volume system after deleting a volume object (case 1348374)

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix APV UI loosing focus when changing a param (#5219)

* Fixed the APV UI losing focus when the helpbox about baking appears in the probe volume.

* Small changes (#5220)

* Fix update order in Graphics Compositor causing jumpy camera updates (#5235)

* Prevent material from having infinite intensity (#5132)

* Prevent material from having infinite intensity

* Fix switching from ldr to hdr emissive

* Fix input field precision

* Round the max value

* Make two variables

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Adding limitations of decal emissive positive contribution to the documentation (#5237)

* Add emissive positive contribution limitation to the doc

* changelog

* Update CHANGELOG.md

* Update Decal-Projector.md

* Update Decal-Shader.md

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix issue with path tracing when switching between non-persistent cameras (#5246)

* Fix issue with path traceing accumulation when switching between cameras.

* Check if camera history is persistent

Co-authored-by: sebastienlagarde <[email protected]>

* removed undesired files

* Fix log base (#5260)

* [HDRP] Fixed mask value stored by the LayerMaskParameter class (#5250)

* Fixed value stored by the layer mask parameter class.

* Updated changelog.

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP][DXR] Make vertex color default to 1.0 instead of 0.0 (#5268)

* When raytracing, make vertex color default to white if not present.

* Updated Changelog.

* Added comment.

* Fix issue with 0-sized dispatch with extremely low resolutions (#5272)

* Ceil to int instead.

* changelog

* [HDRP] Fix incorrect light list indexing when TAA is enabled (#5287)

* Fix incorrect light list indexing when TAA is enabled

* Better handle XR

Co-authored-by: sebastienlagarde <[email protected]>

* Fix incorrect additiona velocity for alembic (#5304)

* Fixed LUT initialization in Wireframe mode (#5156)

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] [LightExplorer] Fix missing refreshwhen editing property with a running paused editor. (#5321)

* Update HDLightExplorerExtension.cs

* Update CHANGELOG.md

* Changed Ambient Mode to Dynamic by default (#5350)

* Visual Environment component ambient mode now defaults to Dynamic.

* Update changelog

* Updated test scene with correct ambient mode after the change

* Missing files

* Last scene fix

* Hd/fix framesettings ordering (#5323)

* Fix strange entry in the FrameSettings and add comments for better readability

* Update CHANGELOG.md

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Bugfix 1357311: Fixed old ray tracing material conversion (#5364)

* - fixed crash in material conversion where material used old raytracing render queue (3900)

* - changelog update

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode" (#5365)

* - fixed missing "Tessellation Mode" tooltip

* - update changelog

* - updated "Tessellation Mode" tooltip

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix HD template (particularly visible in path tracing) (#5319)

* Made the 3 light bulbs non shadow-casting.

* Revert "Made the 3 light bulbs non shadow-casting."

This reverts commit f32ba7d.

* Changed bulb prefab (shadow caster off).

* Revert: Changed Ambient Mode to Dynamic by default #5350

* Fixed a null ref exception when no opaque objects are rendered. (#5463)

* Fixed a null ref exception when no opaque objects are rendered.

* Update changelog

* Fix slope scale depth bias when depth offset is ON (#5466)

* Fix slope scale bias being broken when depth offset was enabled

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix spot shadow sampling when using custom spot angle (#5439)

* Fixed shadow sampling artifact when using the spot light shadow option 'custom spot angle'

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix darkening in SSR fade  (#5472)

* Fix

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Improve path traced subsurface scattering for transmissive surfaces (#5485)

* Improve subsurface scatering for transmissive surfaces

* Add changelog + fix throughput multiplication

Co-authored-by: sebastienlagarde <[email protected]>

* Fix missing context menu for 'Post Anti-Aliasing' in Camera (1357283) (#5497)

Co-authored-by: sebastienlagarde <[email protected]>

* Force allocate texture if no fallback is available (#5130)

Co-authored-by: sebastienlagarde <[email protected]>

* Update path tracer screenshots

* Update 2314_Shadow_CustonAngle.png

* Fix range compression factor clamping (#5892)

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed tooltip not showing on labels in ShaderGraphs (#5877)

Co-authored-by: sebastienlagarde <[email protected]>

* Proper format for copy history (#5796)

* Fix shadow mask fade and optimize it at same time  (#5911)

* Fix shadow mask fade and optimize.

* changelog

* Fix wrong format for contact shadows and shadow atlas default textures  (#5912)

* Fix contact shadows not being bound in debug and good default shadow

* changelog

* Rename

* Handle more edge cases where shadows are not drawn to atlas (disabled scene view lighting)

Co-authored-by: John Parsaie <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>

* Fixed an issue where probe being forced realtime would cause perf to degrade greatly when manipulating them in editor. (#5901)

* Mark anchor override as not supported for probes (#5939)

* Revert: Fix shadow mask fade and optimize it at same time #5911

* Add info on After post-process info box (#6125)

* Add info on info box

* Clarify a bit better

* Dynamic Ambient improvement and doc update (#5951)

* Avoided unnecessary ambient probe updates

Updated doc with dynamic ambient probe limitations

* Update Environment-Lighting.md

Co-authored-by: sebastienlagarde <[email protected]>

* [SRP] Fix issue when changing volume profiles at runtime with a script (#5882)

* Fix issue when changing volume profiles in runtime with a script

* Add new kine in changelog

* Improve comment

* Changelog typo

Co-authored-by: sebastienlagarde <[email protected]>

* Fix NaN on Intel GPU when using PBR Sky and rendering sun disk  (#6145)

* Enable debug symbols

* tentative

* test using cos from cpu

* Finalize fix

* Missing file

* Remove debug symbols.

* Fix Luminance/EV conversion when LightMeterCalibrationConstant is changed (#6115)

* Fix formmating

* Fixed range fields for depth of field

* Revert "Fixed range fields for depth of field"

This reverts commit a34f336.

* fix changelog

* [HDRP] Fix rasterized accumulation motion blur when DoF is enabled (#6380)

* Fix rasterized accumulation motion blur when DoF is enabled

* Update CHANGELOG.md

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Fix light flare for pbr sky (#6278)

* Fix Template directional light

* Fix when using multiple directional lights with flare

* restore default flare on template

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix light mode disabled in some cases (#6283)

* Fixed light mode not available after switching a light to area "Disc" or "Tube" (case 1372588).

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix CoC size computation when dynamic resolution is enabled (#6357)

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Fix cascade blend transition when using an high normal bias (#6288)

* Fix

* Changelog

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed broken rendering when duplicating a camera while the Rendering Debugger is opened. (#6289)

* Fixed broken rendering when duplicating a camera while the Rendering Debugger is opened.

* Update changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix for screen space shadows debug view not showing when no screen space shadows. (#6290)

* Push white texture for debug Screen space shadows.

* changelog

* Fix

* Changelog

* Clarifying something

* Revert "Clarifying something"

This reverts commit 31ce9c7.

* Revert "Changelog"

This reverts commit 860567a.

* Revert "Fix"

This reverts commit 1ec136c.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed null ref (#6297)

* Fixed an issue causing Render Graph execution errors after a random amount of time. (#6329)

* Fixed an issue causing Render Graph execution errors after a random amount of time.

* Made sure of no collision when going for fallback validity bits

* Update CHANGELOG.md

* Fix nullref in non dev build (#6327)

* Fix nullref in non dev build

* Don't add component

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Fix debug window reset (#6325)

* Fix debug window reset

* Don't add component

* Revert "Don't add component"

This reverts commit 765b93b.

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Fixed camera bridge action in release build (#6313)

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Fix for shadows disappearing when no dynamic shadow caster is available (#6296)

* Fix

* Changelog

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Clarifying something

* fix raytraced version

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed directional light height fog attenuation (#6318)

* Disable Atmospheric Scattering when Scene Lighting is Disabled (#6328)

* Disable atmospheric scattering for matcap debug lighting mode

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Use uint as loop variable for directional lights in contact shadows.

* Fix color curves changes not applying immediately in editor (#6322)

* Always recompute LUT hash when colro curves are overridden

* Changelog

* Missing tiny part of comment

Co-authored-by: sebastienlagarde <[email protected]>

* Test

* Revert "Test"

This reverts commit 4ffd193.

* Update 112_Reflection_AlternativeSGNodes.png

* Update CHANGELOG.md

* Fixed Normal Map assiignation when importing FBX Materials (#6491)

Co-authored-by: sebastienlagarde <[email protected]>

* Fix sky jittering (#6678)

* Make sky shadow multi compile global instead of local (#6838)

* make kw not local

* changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Change default custom pass format to R8G8B8A8_UNorm (#6854)

* Change the default custom pass buffer format to R8G8B8A8_UNorm

* update doc

* updated changelog

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <[email protected]>

* Fix simple lit pass not using the correct pass name for depth (#6810)

* Fix simple lit pass not using the correct pass name for depth

* Fix VFX Simple Lit not compiling when switching HDRP asset to forward

* Fix simple lit on planar primitive as well

* updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* fix changelog

* Update CHANGELOG.md

* Updated screenshot (#6881)

* Updated screenshot

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <[email protected]>

* note formatting and typo (#6880)

* Fix cached directional shadows disappearing when going out of shadow range to never reappear (#6802)

* fix

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed an issue where sometimes full screen debug would cause render graph errors. (#6803)

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed a nullref exception when creating a new scene while LightExplorer is open. (#6805)

Co-authored-by: sebastienlagarde <[email protected]>

* Stop Uber from running if no effect that needs it is enabled (#6804)

* Fix

* changelog

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <[email protected]>

* Register shadows OnDemand to the cached shadow system only when rendered for the first time. (#6825)

* Fix a couple of issues

* Changelog

* Change how the registering to the sysem works for ondemand

* Changelog

* Fix wrong warning

Co-authored-by: sebastienlagarde <[email protected]>

* comments and old PR revert. (#6827)

* Fix for issue with SSAO (and in fact anything sampling depth pyramid) at edges (#6839)

* tentative fix

* changelog

* right parenthesis

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Update custom pass doc (decals not supported by DrawRenderers custom pass) (#6858)

* update custom pass doc

* Update Custom-Pass-Creating.md

Co-authored-by: sebastienlagarde <[email protected]>

* Rename vertex color mode option (#6795)

* Rename vertex color mode option

* Update doc

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* use correct index for light shadow (#6847)

Co-authored-by: sebastienlagarde <[email protected]>

* Fix issue with accumulation motion blur and depth of field when path tracing is enabled (#6952)

Co-authored-by: sebastienlagarde <[email protected]>

* Fix first frame of SSR PRB Accumulation (#5324)

* Fix first frame for SSR Accumulation algorithm

* Add ChangeLog

* Fix CHANGELOG merge

* Initial commit - update the docs (#6819)

* Fix for sampling garbage outside of screen with low res transparent upsample and dynamic resolution (#6957)

* Fix

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

Co-authored-by: Pavlos Mavridis <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: John Parsaie <[email protected]>
Co-authored-by: anisunity <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: CifaCia <[email protected]>
Co-authored-by: Adrien de Tocqueville <[email protected]>
Co-authored-by: slunity <[email protected]>
Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: Emmanuel Turquin <[email protected]>
Co-authored-by: Adrian1066 <[email protected]>
Co-authored-by: Kleber Garcia <[email protected]>
Co-authored-by: Julien Ignace <[email protected]>
Co-authored-by: alex-vazquez <[email protected]>
Co-authored-by: Rémi Chapelain <[email protected]>
Co-authored-by: Remi Slysz <[email protected]>
Co-authored-by: Jarkko Lempiäinen <[email protected]>
Co-authored-by: FrancescoC-Unity <[email protected]>
Co-authored-by: emilybrown1 <[email protected]>
Co-authored-by: skhiat <[email protected]>

Author: 19 people

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -110,6 +110,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed the roughness value used for screen space reflections and ray traced reflections to match environment lighting (case 1390916).
 - Fixed editor issue with the LiftGammaGain and ShadowsMidtonesHighlights volume components.
 - Fixed using the wrong directional light data for clouds and the definition of current Sun when the shadow pass is culled (case 1399000).
+- Fixed vertex color mode Add name whicgh was misleading, renamed to AddSubstract.
+- Fixed screen space shadow when multiple lights cast shadows.
+- Fixed issue with accumulation motion blur and depth of field when path tracing is enabled.
+- Fixed issue with dynamic resolution and low res transparency sampling garbage outside of the render target.
 
 ## [14.0.0] - 2021-11-17
 

com.unity.render-pipelines.high-definition/Documentation~/Post-Processing-Bloom.md

@@ -54,3 +54,6 @@ From 2019.3, HDRP provides lookup Textures that you can use to customize this ef
 2. In the **Packages** window, select **High Definition RP**.
 3. In the **High Definition RP** section, navigate to **Additional Post-processing Data** and click **Import into Project** next to it.
 4. The Textures that are relevant to Bloom are in the **Lens Dirt** folder, so if you only want the lookup Textures for Bloom, only import the contents of the **Lens Dirt** folder.
+
+
+Care is needed when using the Bloom effect with [Chromatic Abberation](Post-Processing-Chromatic-Aberration.md). For performance reasons, Chromatic Aberation is computed after the Bloom computation. This results in Bloom overpowering the Chromatic Aberration effect when the Bloom Intensity is set to a very high value. However, in a typical Bloom configuration, the Intensity should never need to be set high enough for this to be an issue.

com.unity.render-pipelines.high-definition/Documentation~/Post-Processing-Chromatic-Aberration.md

@@ -31,3 +31,5 @@ From 2019.3, HDRP provides lookup Textures that you can use to customize this ef
 2. In the **Packages** window, select **High Definition RP**.
 3. In the **High Definition RP** section, navigate to **Additional Post-processing Data** and click **Import into Project** next to it.
 4. The Textures that are relevant to Chromatic Aberration are in the **Spectral LUTs** folder,  so if you only want the lookup Textures for Chromatic Aberration, only import the contents of the **Spectral LUTs** folder.
+
+Care is needed when using the [Bloom](Post-Processing-Bloom.md) effect with Chromatic Abberation. For performance reasons, Chromatic Aberation is computed after the Bloom computation. This results in Bloom overpowering the Chromatic Aberration effect when the Bloom Intensity is set to a very high value. However, in a typical Bloom configuration, the Intensity should never need to be set high enough for this to be an issue.

com.unity.render-pipelines.high-definition/Documentation~/snippets/shader-properties/surface-inputs/layered-surface-inputs.md

@@ -6,7 +6,7 @@
 | **World Scale**                              | Set the world-space size of the Texture in meters. If you set this to **1**, then HDRP maps the Texture to 1 meter in world space.If you set this to **2**, then HDRP maps the Texture to 0.5 meters in world space.This property only appears when you select **Planar** or **Triplanar** from the **BlendMask UV Mapping** drop-down. |
 | **Tiling**                                   | Set an **X** and **Y** tile rate for the **Layer Mask** UV. HDRP uses the **X** and **Y** values to tile the Texture assigned to the **Layer Mask** across the Material’s surface, in object space. |
 | **Offset**                                   | Set an **X** and **Y** offset for the **Layer Mask** UV. HDRP uses the **X** and **Y** values to offset the Texture assigned to the **Layer Mask** from the Material’s surface, in object space. |
-| **Vertex Color Mode**                        | Use the drop-down to select the method HDRP uses to combine the **Layer Mask** to manager layer visibility.<br/>&#8226; **None**: Only the **Layer Mask** affects visibility. HDRP does not combine it with vertex colors.<br/>&#8226; **Multiply**: Multiplies the vertex colors from a layer with the corresponding values from the channel in the **Layer Mask** that represents that layer. The default value for a pixel in the mask is 1. Multiplying the vertex colors of a layer by the **Layer Mask** reduces the intensity of that layer, unless the value in the **Layer Mask** is 1.<br/>&#8226; **Add**: Remaps vertex color values to between -1 and 1, and then adds them to the corresponding values from the channel in the **Layer Mask** that represents that layer. Vertex color values between 0 and 0.5 reduce the effect of that layer, values between 0.5 and 1 increase the effect of that layer. |
+| **Vertex Color Mode**                        | Use the drop-down to select the method HDRP uses to combine the **Layer Mask** to manager layer visibility.<br/>&#8226; **None**: Only the **Layer Mask** affects visibility. HDRP does not combine it with vertex colors.<br/>&#8226; **Multiply**: Multiplies the vertex colors from a layer with the corresponding values from the channel in the **Layer Mask** that represents that layer. The default value for a pixel in the mask is 1. Multiplying the vertex colors of a layer by the **Layer Mask** reduces the intensity of that layer, unless the value in the **Layer Mask** is 1.<br/>&#8226; **AddSubstract**: Remaps vertex color values to between -1 and 1, and then adds them to the corresponding values from the channel in the **Layer Mask** that represents that layer. Vertex color values between 0 and 0.5 reduce the effect of that layer, values between 0.5 and 1 increase the effect of that layer. |
 | **Main Layer Influence**                     | Enable the checkbox to allow the **Main Layer** to influence the albedo, normal, and height of **Layer 1**, **Layer 2**, and **Layer 3**. You can change the strength of the influence for each layer. |
 | **Use Height Based Blend**                   | Enable the checkbox to blend the layers with a heightmap. HDRP then evaluates the height of each layer to check whether to display that layer or the layer above. |
 | **Height Transition**                        | Use the slider to set the transition blend size between the Materials in each layer. |

com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadows.shader

@@ -65,7 +65,7 @@ Shader "Hidden/HDRP/ScreenSpaceShadows"
             float3 normalWS = normalData.normalWS;
 
             // Note: we use shading normal here and not GetNormalForShadowBias() as it is not available
-            return GetDirectionalShadowAttenuation(context.shadowContext, posInput.positionSS.xy, posInput.positionWS, normalWS, _DirectionalShadowIndex, L);
+            return GetDirectionalShadowAttenuation(context.shadowContext, posInput.positionSS.xy, posInput.positionWS, normalWS, light.shadowIndex, L);
         }
     ENDHLSL
 

com.unity.render-pipelines.high-definition/Runtime/Material/LayeredLit/LayeredLit.shader

@@ -245,7 +245,7 @@ Shader "HDRP/LayeredLit"
 
         [HideInInspector] _LayerCount("_LayerCount", Float) = 2.0
 
-        [Enum(None, 0, Multiply, 1, Add, 2)] _VertexColorMode("Vertex color mode", Float) = 0
+        [Enum(None, 0, Multiply, 1, AddSubstract, 2)] _VertexColorMode("Vertex color mode", Float) = 0
 
         [ToggleUI]  _ObjectScaleAffectTile("_ObjectScaleAffectTile", Float) = 0.0
         [Enum(UV0, 0, UV1, 1, UV2, 2, UV3, 3, Planar, 4, Triplanar, 5)] _UVBlendMask("UV Set for blendMask", Float) = 0

com.unity.render-pipelines.high-definition/Runtime/Material/LayeredLit/LayeredLitTessellation.shader

@@ -245,7 +245,7 @@ Shader "HDRP/LayeredLitTessellation"
 
         [HideInInspector] _LayerCount("_LayerCount", Float) = 2.0
 
-        [Enum(None, 0, Multiply, 1, Add, 2)] _VertexColorMode("Vertex color mode", Float) = 0
+        [Enum(None, 0, Multiply, 1, AddSubstract, 2)] _VertexColorMode("Vertex color mode", Float) = 0
 
         [ToggleUI]  _ObjectScaleAffectTile("_ObjectScaleAffectTile", Float) = 0.0
         [Enum(UV0, 0, UV1, 1, UV2, 2, UV3, 3, Planar, 4, Triplanar, 5)] _UVBlendMask("UV Set for blendMask", Float) = 0

com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs

@@ -1123,7 +1123,7 @@ void UpdateSSRConstantBuffer(HDCamera hdCamera, ScreenSpaceReflection settings,
             cb._ColorPyramidUvScaleAndLimitPrevFrame = HDUtils.ComputeViewportScaleAndLimit(hdCamera.historyRTHandleProperties.previousViewportSize, hdCamera.historyRTHandleProperties.previousRenderTargetSize);
             cb._SsrColorPyramidMaxMip = hdCamera.colorPyramidHistoryMipCount - 1;
             cb._SsrDepthPyramidMaxMip = hdCamera.depthBufferMipChainInfo.mipLevelCount - 1;
-            if (hdCamera.isFirstFrame || hdCamera.cameraFrameCount <= 2)
+            if (hdCamera.isFirstFrame || hdCamera.cameraFrameCount <= 3)
             {
                 cb._SsrAccumulationAmount = 1.0f;
             }

com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.PostProcess.cs

@@ -538,7 +538,7 @@ TextureHandle RenderPostProcess(RenderGraph renderGraph,
 
                 source = DepthOfFieldPass(renderGraph, hdCamera, depthBuffer, motionVectors, depthBufferMipChain, source, depthMinMaxAvgMSAA, prepassOutput.stencilBuffer);
 
-                if (m_DepthOfField.IsActive() && m_SubFrameManager.isRecording && m_SubFrameManager.subFrameCount > 1)
+                if (m_DepthOfField.IsActive() && m_SubFrameManager.isRecording && m_SubFrameManager.subFrameCount > 1 && !m_PathTracing.enable.value)
                 {
                     RenderAccumulation(m_RenderGraph, hdCamera, source, source, false);
                 }

com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/UpsampleTransparent.shader

@@ -97,7 +97,9 @@ Shader "Hidden/HDRP/UpsampleTransparent"
 #if DEBUG_EDGE
                 return float4(0.0, 10.0, 0.0, 1.0);
 #else
-                return SAMPLE_TEXTURE2D_X_LOD(_LowResTransparent, s_point_clamp_sampler, ClampAndScaleUVForPoint(nearestUV), 0);
+                // Important note! The reason we need to do ClampAndScaleUVForBilinear is because the candidate for nearestUV are going to be the ones
+                // used for bilinear. We are using the same UVs used for bilinear -hence the uv clamp for bilinear- it is just the filtering that is different.
+                return SAMPLE_TEXTURE2D_X_LOD(_LowResTransparent, s_point_clamp_sampler, ClampAndScaleUVForBilinear(nearestUV), 0);
 #endif
             }
         #else // BILINEAR