Ethers V6 Upgrade

[jfbloom22]

Any interest in updating the SDKs to Ethers V6? I am really enjoying using BigInts rather than BigNumber. Happy to help with this effort.

Which SDKs need to be updated for Ethers V6?

• permit2-sdk
• universal-router-sdk
• uniswapx-sdk
• v4-sdk

[SergioArrighi]

+1

Surely v4-sdk, I don't know about the others.
I got there while trying to migrate ImmutableX ts sdk.

Regards

[arcolife]

+1 on ethers v6 for uniswapx-sdk

[Amxx]

I noticed that in some places, the SDK uses ethers v5 "directly" by importing ethers/... instead of @ethersproject/...
See:

sdks/sdks/v4-sdk/src/entities/pool.ts

Line 13 in a8713a0

import { defaultAbiCoder, isAddress } from 'ethers/lib/utils'

This causes conflicts when using the SDK with other packages that depend on ethers v6.

Should I open a PR to fix these imports before the transition to v6 happens ?

[jsy1218]

sorry to be a bummer, but uniswap tech stack across frontend, backend, and protocol is largely on ethers-v5 - https://github.com/search?q=org%3AUniswap+ethers-v5&type=code.

sadly, v4-sdk is a dependency to router-sdk/universal-router-sdk, which then gets used in various repos, so that if uniswap were to upgrade to ethers-v5, I see non-trivial effort. worth keeping this issue though, because ethers-v5 is not state-of-the-art

[haowang1013]

Can you guys at least declare the ethers.js v5 dependency correctly rather than assuming whatever version the depending package uses is correct? That way npm will install a v5 for your package even if the depending package uses v6.

[andrewverify]

as per @haowang1013, need the uniswapX SDK to load v5 as a dependency in order to be able to use it with hardhat and other libraries that use v6. Right now we have to solve a lot of conflicts between the way v5 and v6 does things like BigNumber / BigInt conversion etc.

[treeder]

I tried getting this working over the past couple of days and got it pretty close I think in this PR: treeder#1.

But after spending way too much time and wrecking my keyboard with tears, I gave up. There's so much legacy stuff spread throughout, dead libraries that haven't been maintained in 5 years, etc. It's just a nightmare in general. If I had a week and didn't care about my time or sanity, I think it could be finished up.

My new plan is to just use this sdk in a separate service and call it via an API as there's no way to get it to work with a modern stack.

[jnsvd]

Also interested in a fix for this. Currently we can't require @uniswap/smart-order-router in projects where we have a hardhat installation that uses ethers v6.

[yuercl]

Here is a method provided, but it is not an elegant solution.

Uniswap/smart-order-router#383