Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deadlines under 30 minutes are automatically clipped to 30 minutes. #7855

Open
AlexNi245 opened this issue Mar 3, 2025 · 0 comments
Open

Comments

@AlexNi245
Copy link

When setting the Tx.deadline field in the Settings Modal below 30 minutes, the value automatically clips to 30 minutes. The modal displays the lower value, but the transaction object stores 30 minutes instead.

Steps to Reproduce

  1. Open the Swap UI and select the token pair to trade.
  2. Open the Settings Modal and set the Deadline to 5 minutes.
  3. Close the Settings Modal.
  4. Reopen the Settings Modal — the Deadline is still set to 5 minutes.
  5. Submit the swap.
  6. View the transaction on Etherscan.
  7. Decode the Input Data.
  8. Notice that the deadline field in the transaction data is creationDate + 30min instead of creationDate + 5min.

Expected Behavior

The transaction's deadline field should equal creationDate + user-specific deadline.

Image

The transaction below demonstrates this behavior, set with a 5-minute deadline but an incorrect deadline field in the transaction data.

https://sepolia.etherscan.io/tx/0xe9dd8a1aa07b78e22155dfc8da929462627bda6c8ffe4ea7f9d1c85fb85e5dc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant