Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [V2, V3, V4] quote is worse than [V3, V4] quote #7852

Open
Nikita-Polyakov opened this issue Feb 25, 2025 · 0 comments
Open

[Bug] [V2, V3, V4] quote is worse than [V3, V4] quote #7852

Nikita-Polyakov opened this issue Feb 25, 2025 · 0 comments

Comments

@Nikita-Polyakov
Copy link

As a user, I expect that I will receive the best exchange result in case:

  1. If I select [V3, V4] protocols
  2. And if I add V2 from the previous set [V3, V4] -> [V2, V3, V4]

But the quote calculation with V2 in set gets worse.

I guess that if the liquidity in V2 does not get profit in quote, it should not be considered, as another protocols are already in set and have a better quote.

bandicam.2025-02-25.13-51-34-223.mp4
@Nikita-Polyakov Nikita-Polyakov changed the title [Bug] [V2 + V3 + V4] quote is worse than [V3 + V4] quote [Bug] [V2, V3, V4] quote is worse than [V3, V4] quote Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant