[BUG] PortAdmin. Port with non-existing vlan is not possible to edit

[ingeborgoh]

Describe the bug

If a switch has a port configured to have a vlan that is not existing on the switch (i.e. due to sloppy routines when removing a vlan) PortAdmin will not let you edit the port: The enabled checkbox is greyed out.

The workaround is to log into the switch and set a proper vlan on the port.

I am not clear on what the GUI should show, but what it does today is confusing. Maybe show an error flag?

[lunkwill42]

A user recently described a similar problem on the mailing list. Currently, I don't think there is a mechanism to communicate this problem to the template that generates the UI (i.e. it is just told by the backend that the port isn't editable, never why it isn't).

If we were to change that, I might prod @podliashanyk for ideas on how we would indicate this kind of problem in a non-intrusive but obvious way in the UI.

[lunkwill42]

We just got a similar report from another user, but in a slight different setting:

In the target network, many trunk ports do not have a native VLAN configured. This also causes PortAdmin to refuse to edit such a trunk port, since it cannot match its native VLAN value as being among the "allowed" ones.

[lunkwill42]

So, #2786 should solve the immediate problem of "invalid native VLANs".

However, another problem remains in the case where a native VLAN is not set at all on a trunk port, as can be the case on platforms like JunOS. PortAdmin will refuse to leave the native vlan unset when changing the configuration of a trunk port, and a native VLAN tag of 1 seems to be set as some sort of default value. This needs to be fixed separately.

[lunkwill42]

Fixed by #2786