Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Improve docs and tests for NcML logical view elements #784

Open
1 of 5 tasks
cwardgar opened this issue Mar 21, 2017 · 3 comments
Open
1 of 5 tasks

Improve docs and tests for NcML logical view elements #784

cwardgar opened this issue Mar 21, 2017 · 3 comments

Comments

@cwardgar
Copy link
Contributor

cwardgar commented Mar 21, 2017

From #778.

  • logicalSection, logicalSlice, and logicalReduce are only briefly described in AnnotatedSchema4.adoc. We should expand on this.
  • Only logicalReduce has an example in AnnotatedSchema4.adoc. All 3 elements should. Ideally, those examples would be drawn from unit tests, so that they're less likely to become stale.
  • The variable Element section doesn't include logicalReduce.
  • Cookbook.adoc includes an example for logicalReduce (the exact same one as in AnnotatedSchema4.adoc), but not the other 2 elements.
  • Only logicalReduce is tested, in TestLogicalReduce.
@cwardgar
Copy link
Contributor Author

Here is one example of logicalSection. I didn't realize before that the logical view stuff are child elements of variable, not attributes of it.

@cofinoa
Copy link
Contributor

cofinoa commented Jul 13, 2017

@cwardgar the most tricky part of logicalSections and slices are the renaming of the anonymous dimensions created when the sections are extracted.

To do the renaming a wrapping with aggregation and netcdf elements are required making quite complex ncml.

The other problem it's about the logical of the ncml parsing it's been made by the CDM library which it's dependent on the order of the elements are been parsed and it's not based on the order they are written.

@cwardgar
Copy link
Contributor Author

cwardgar commented Jan 5, 2018

#998 addresses the last item by replacing the crappy TestLogicalReduce with LogicalViewsSpec.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants