Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue #3535 #3549

Merged
merged 14 commits into from
Jul 9, 2024
Merged

fixes issue #3535 #3549

merged 14 commits into from
Jul 9, 2024

Conversation

anacmontoya
Copy link
Contributor

@anacmontoya anacmontoya commented Jun 24, 2024 •
edited
Loading

@anacmontoya anacmontoya requested a review from a team as a code owner June 24, 2024 18:00
@anacmontoya anacmontoya requested review from dopplershift and removed request for a team June 24, 2024 18:00
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 24, 2024
View reviewed changes
tests/io/test_text.py Fixed Show fixed Hide fixed
anacmontoya
anacmontoya commented Jun 25, 2024
View reviewed changes
tests/io/test_text.py Outdated Show resolved Hide resolved
tests/io/test_text.py Outdated Show resolved Hide resolved
@dcamron dcamron added Type: Bug Something is not working like it should Area: IO Pertains to reading data labels Jun 25, 2024
@dcamron dcamron added this to the 1.6.3 milestone Jun 25, 2024
dopplershift
dopplershift requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks great. I'd like to go a different way with the testing; in general, it's best to always test the public API and not test internal functions.

tests/io/test_text.py Outdated Show resolved Hide resolved
tests/io/test_text.py Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2024
View reviewed changes
tests/io/test_text.py Fixed Show fixed Hide fixed
dopplershift
dopplershift approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@dopplershift dopplershift merged commit 7997bfe into Unidata:main Jul 9, 2024
34 checks passed
@anacmontoya anacmontoya deleted the wpc-bulletin-coords branch July 15, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Area: IO Pertains to reading data Type: Bug Something is not working like it should
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.

WPC Surface Bulletins for the southern hemisphere are not being parsed correctly
4 participants
@anacmontoya @CLAassistant @dopplershift @dcamron