Line 183 of the GridFieldSortableRows.php is producing problems

[ghost]

Hi!

The line 183 of the GridFieldSortableRows.php is producing problems:

DB::query('UPDATE "' . $table
. '" SET "' . $sortColumn . '" = ' . $sortColumn = ($max + $i)
. ' WHERE "ID" = '. $obj->ID);

I think it should be:

DB::query('UPDATE "' . $table
. '" SET "' . $sortColumn . '" = ' .  ($max + $i)
. ' WHERE "ID" = '. $obj->ID);

Regards,
Jose A.

[UndefinedOffset]

Jose,
I'm not seeing a difference in the two snippets? I'll have a closer look tomorrow night. See if I can see what's up then.

[ghost]

The difference is that you put: . $sortColumn = ($max + $i)
when it should be: . ($max + $i)

Regards,
Jose A.

[UndefinedOffset]

Fixed in master thanks to pull request 25

[UndefinedOffset]

Thanks Jose, it was like 12:30am when i was looking lol, brain was kinda turned off lol. Like I said earlier its fixed thanks to pull #25 curtsy of flxbot