Skip to content

Trim excess in long lived font collections #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

Trim excess in long lived font collections #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/UglyToad.PdfPig.Fonts/CompactFontFormat/CharStrings/Type2CharStringParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,8 @@ private static Type2CharStrings.CommandSequence ParseSingle(
}
}

values.TrimExcess();

return new Type2CharStrings.CommandSequence(values, commandIdentifiers);
}

Expand Down
4 changes: 4 additions & 0 deletions src/UglyToad.PdfPig.Fonts/CompactFontFormat/Charsets/CompactFontFormatIsoAdobeCharset.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,10 @@ private CompactFontFormatIsoAdobeCharset()
gidToStringIdAndNameMap[gid++] = pair;
}

#if NET
gidToStringIdAndNameMap.TrimExcess();
#endif

glyphIdToStringIdAndName = gidToStringIdAndNameMap;
}

Expand Down
10 changes: 7 additions & 3 deletions src/UglyToad.PdfPig/PdfFonts/Cmap/CharacterMapBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,15 @@ public void AddBaseFontCharacter(ReadOnlySpan<byte> bytes, string value)

public CMap Build()
{
#if NET
BaseFontCharacterMap?.TrimExcess();
#endif

return new CMap(GetCidSystemInfo(), Type, WMode, Name, Version,
BaseFontCharacterMap ?? new Dictionary<int, string>(),
CodespaceRanges ?? new CodespaceRange[0],
CidRanges ?? new CidRange[0],
CidCharacterMappings ?? new CidCharacterMapping[0]);
CodespaceRanges ?? Array.Empty<CodespaceRange>(),
CidRanges ?? Array.Empty<CidRange>(),
CidCharacterMappings ?? Array.Empty<CidCharacterMapping>());
}

private CharacterIdentifierSystemInfo GetCidSystemInfo()
Expand Down
Loading