Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional **kwargs for opening a grid file with ux.open_dataset #386

Closed
philipc2 opened this issue Jul 18, 2023 · 0 comments · Fixed by #390
Closed

Add additional **kwargs for opening a grid file with ux.open_dataset #386

philipc2 opened this issue Jul 18, 2023 · 0 comments · Fixed by #390
Assignees
@philipc2
Labels
new feature New feature or request
Milestone
Core

Comments

@philipc2
Copy link
Member

Related to #385 & #384

Using ux.open_dataset with a separate grid and data file does not allow for passing in arguments in the subsequent xr.open_dataset call that happens in ux.open_grid, restricting the user (see #385)

Add the ability to pass through **grid_kwargs or similar into ux.open_dataset to specify the behavior of xr.open_dataset when opening a grid file
@philipc2 philipc2 added the new feature New feature or request label Jul 18, 2023
@philipc2 philipc2 changed the title Add additional**kwargs for opening a grid file with ux.open_dataset Add additional **kwargs for opening a grid file with ux.open_dataset Jul 18, 2023
@philipc2 philipc2 self-assigned this Jul 18, 2023
@philipc2 philipc2 moved this from 📝 To Do to 🏗 In progress in UXarray Development Jul 18, 2023
This was linked to pull requests Jul 18, 2023
added another kwargs for read in #384
Closed
Separate kwargs for Opening a Grid File in Open Dataset #390
Merged
@philipc2 philipc2 mentioned this issue Jul 19, 2023
Merged
8 tasks
@philipc2 philipc2 moved this from 🏗 In progress to 👀 In review in UXarray Development Jul 20, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UXarray Development Jul 20, 2023
@erogluorhan erogluorhan added this to the Core - Grid milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipc2 philipc2

Labels
new feature New feature or request
Projects
UXarray Development
Status: ✅ Done
Milestone
Core
2 participants
@erogluorhan @philipc2