Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Bug Fix: Improper QR_GUI implementation #815

Closed
yashksaini-coder opened this issue Oct 23, 2024 · 2 comments · Fixed by #834
Closed

🐛Bug Fix: Improper QR_GUI implementation #815

yashksaini-coder opened this issue Oct 23, 2024 · 2 comments · Fixed by #834
Assignees
Labels
Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. gssoc-ext hacktoberfest level3 Status: Assigned💻 Indicates an issue has been assigned to a contributor.

Comments

@yashksaini-coder
Copy link
Contributor

Title

Improper QR_GUI implementation

Bug

Few bugs & issues i found that:-

  1. Error Handling Issues
  2. Image Display Problems
  3. File Operations
  4. Variable Scope Issues
  5. UI/UX Issues
  6. Theme Toggle Bug

Changes

Here are the issues and their respective fixes:

Issue Title Changes Made
Empty Input Validation Added input checks: if not link or not name: messagebox.showerror()
Memory Leak - Image Display Added cleanup: if self.image_label: self.image_label.destroy()
File Management - Added file existence check: if os.path.exists(file_path)
- Added overwrite confirmation
- Implemented temporary file cleanup
Global Variables - Converted to class-based structure
- Replaced globals with class attributes (self.img, self.image_label)
Error Feedback Added message boxes for:
- Generation errors
- Save success/failure
- Input validation
Resource Cleanup - Added proper file cleanup with os.remove()
- Added proper image closing
- Implemented temporary file handling
Theme Toggle - Fixed case comparison in theme check
- Improved theme state management
Exception Handling Added try-except blocks for:
- QR generation
- File operations
- Image handling

Screenshots 📷

image
image

Full Name

Yash Kumar Saini

Participant Role

GSSoC-ext

Copy link

🙌 Thank you for bringing this issue to our attention! We appreciate your input and will investigate it as soon as possible.

Feel free to join our community on Discord to discuss more!

@yashksaini-coder yashksaini-coder changed the title 🐛: Improper QR_GUI implementation 🐛Bug Fix: Improper QR_GUI implementation Oct 23, 2024
@UTSAVS26 UTSAVS26 added Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. Status: Assigned💻 Indicates an issue has been assigned to a contributor. level3 gssoc-ext hacktoberfest labels Oct 24, 2024
Copy link

✅ This issue has been closed. Thank you for your contribution! If you have any further questions or issues, feel free to join our community on Discord to discuss more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. gssoc-ext hacktoberfest level3 Status: Assigned💻 Indicates an issue has been assigned to a contributor.
Projects
None yet
2 participants