Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect system theme for dark/light mode #28

Open
WillieCubed opened this issue Feb 18, 2022 · 3 comments
Open

Respect system theme for dark/light mode #28

WillieCubed opened this issue Feb 18, 2022 · 3 comments
Labels
Good First Issue Good for newcomers Type: Feature Request New feature or request

Comments

@WillieCubed
Copy link
Member

WillieCubed commented Feb 18, 2022

Overview

The website currently has a dark mode switch, but it defaults to using the light theme. It would be ideal if a user didn't have to update the switch to view the website in their preferred color scheme.

Proposal

The website should respect the user's color scheme (dark/light). Specifically, it should use the browser's built-in color scheme (dark/light) and use the system theme.

Supplementary Information

The Docusaurus docs should give enough information to resolve this.

Also, shout-out to @Jake3231 for catching this!

@WillieCubed WillieCubed added Type: Feature Request New feature or request Good First Issue Good for newcomers labels Feb 18, 2022
@WillieCubed WillieCubed self-assigned this Feb 18, 2022
@WillieCubed WillieCubed moved this to Todo in Up For Grabs Feb 18, 2022
@WillieCubed WillieCubed removed their assignment Feb 18, 2022
@Jake3231
Copy link

It looks like the website correctly responds to system appearance changes, but returns to the default light theme upon reloading the page.

Tested:
Safari for iOS 15.3.1 (Current release version)
Safari for macOS 12.3 beta 3

@Jake3231
Copy link

On both Chrome and Safari, the website may also intermittently load initially with the default appearance, while still responding to system appearance changes after that point.

@michaelgrav
Copy link

The website correctly responds to system appearance changes on my Mac as well, but on windows it does not respond to changes.

Tested:
Firefox 97 for macOS (Current release version)
Firefox 97 for Windows 10 (Also current release version)

@connorwinston connorwinston linked a pull request Mar 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Type: Feature Request New feature or request
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants