Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Prevent opening empty search results #293

Open
TyHil opened this issue Oct 30, 2024 · 0 comments
Open

[Feature Request] Prevent opening empty search results #293

TyHil opened this issue Oct 30, 2024 · 0 comments
Assignees
@ajlikesoj
Labels
Good First Issue Good for newcomers Type: Feature Request New feature or request

Comments

@TyHil
Copy link
Member

TyHil commented Oct 30, 2024 •
edited
Loading

Overview

Skedge prevents rows with no data from being opened, Trends should as well

Proposal

Copy over the canOpen functionality from searchResultsTable in skedge

https://github.com/UTDNebula/skedge/blob/6b425d075c71ca05a956ad7ec2002830025dc97e/src/components/SearchResultsTable.tsx#L44-L46

Supplementary Information

Example of what shouldn't happen:

image

And the functionality in skedge:

image
@TyHil TyHil added Type: Feature Request New feature or request Good First Issue Good for newcomers labels Oct 30, 2024
@ajlikesoj ajlikesoj self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajlikesoj ajlikesoj

Labels
Good First Issue Good for newcomers Type: Feature Request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TyHil @ajlikesoj