-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] On a new search, switch to the newest source of information (Professor/Course Overview tab) on the RHS + When adding a course to compare, switch to that tab #210
Comments
Unintended side effect is it keeps going to tab index 0 when I click to add something to compare |
Did not mean to close the issue. |
no worries! |
Now that we've had some time to develop the user-experience on Trends, is this something we still want to do? On one had, we would be taking action without user input to switch tabs, but that would allow the user to see newly-loaded overview information |
@TyHil I don't know what to do with this issue. I don't want to take action on behalf of the user. Maybe a notification badge instead? Also, should we revisit switching to the compare page when you add to compare? |
I think this is still a reasonable change. If I'm adding to my search, the whole page is changing, its ok for the RHS to change too. And if I'm adding a prof it should definitely change to show me info for that prof
I think this is a must for anyone to even know we have a compare feature. Besides, its saving me a click cause whats the next thing I do after adding something to compare |
So then this Issue is going to also include the switch to compare when a new course is checked @harshptl05 @TatvikReddy do both of you want to continue working on this? |
|
Overview
Why: So the user can see the new information loaded on a search. Also the compare tab does not have new information during a new search. This is for a "second search", so after I search for cs 2337, if I search for John Cole, the RHS carousel should default to showing the Professor Overview tab.
The text was updated successfully, but these errors were encountered: