Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NP-96): Allow valid major double dipping #682

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

akevinge
Copy link
Member

Allows double dipping for major validation but not free electives. Slightly jank fix but I think we can rely on free electives always being there for ECS majors at least.

@akevinge akevinge requested a review from a team as a code owner September 25, 2023 22:02
@akevinge akevinge requested a review from jasonappah September 25, 2023 22:02
@github-actions
Copy link

@akevinge akevinge requested review from cubetastic33 and removed request for jasonappah September 26, 2023 02:01
Copy link
Member

@cubetastic33 cubetastic33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cubetastic33 cubetastic33 merged commit 584835c into develop Oct 2, 2023
4 checks passed
@cubetastic33 cubetastic33 deleted the fix-valid-major-double-dipping branch October 2, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants