Upgrade Vue.js CLI to 4.x #969
Conversation
…n error, see vuejs/vue-router#2881 (comment). It seems it's not supposed to throw the error if parameters are changed, so maybe a bug in vue-router?
* Security fixes
| else | ||
| cat static/js/admin/vue-permissions-editor/dist/app.js >> static/js/vue-permissions.js | ||
| endif | ||
| cat static/js/admin/vue-permissions-editor/dist/js/app*js >> static/js/vue-permissions.js |
There was a problem hiding this comment.
Just checking, but is the case now that we don't need to change behaviors depending on the deploy type for the permissions editor js, but do still need to for the css?
There was a problem hiding this comment.
Correct, the JS files should be the same now across deployment types. In the dev build the css still get bundled into the JS files.
| this.$router.push({ name: 'displayRecords', query: this.urlParams(update_params) }); | ||
| this.$router.push({ name: 'displayRecords', query: this.urlParams(update_params) }) | ||
| .catch((e) => { | ||
| if (e.name !== 'NavigationDuplicated') { |
There was a problem hiding this comment.
what triggers NavigationDuplicated errors? Something like clicking twice on a link?
There was a problem hiding this comment.
I think that or trying to redirect to the same url you're at. If I read the ticket mentioned in the commit correctly, it shouldn't give this error if you update parameters. It's possible that doesn't include parameters's specified via the ?. It might only refer to params in the route, like :uuid in our case. Not catching the error doesn't break anything, but it does throw a bunch of warnings in the tests.
| @@ -9,7 +10,7 @@ localVue.use(VueRouter); | |||
|
|
|||
| const updated_uuid = 'c03a4bd7-25f4-4a6c-a68d-fedc4251b680'; | |||
| const title = 'Test Collection'; | |||
| const response = `<table><tbody><tr><th>Creator</th> <td><p>Real Dean</p></td></tr></tbody></table>`; | |||
| const response = pretty(`<table><tbody><tr><th>Creator</th><td><p>Real Dean</p></td></tr></tbody></table>`); | |||
There was a problem hiding this comment.
Real dean is getting prettified!
There was a problem hiding this comment.
Yeah, vue test utils changed how they return HTML. It used to have no spaces, but they switched to formatting the HTML with the pretty package before returning it.
|
The big change was vue-test-utils stopped running actions within tests synchronously. Hence all the async awaits scattered around in the tests. |
https://jira.lib.unc.edu/browse/BXC-2523