This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
added ability to corrupt wind sensors #264
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamenkaye
commented
Nov 20, 2021
jamenkaye
commented
- Should I write more documentation for how to use this code? Should I update the readme document?
- What is the convention for wind direction angles here? I'm assuming angles need to be on [0, 360) and would need to make a small change otherwise
- Please let me know if there are any other issues or if I should add something else!
|
Should I write more documentation for how to use this code? Should I update the readme document?
What is the convention for wind direction angles here? I'm assuming angles need to be on [0, 360) and would need to make a small change otherwise
|
tylerlum
reviewed
Nov 23, 2021
|
Clean way to throttle updates: |
tylerlum
reviewed
Nov 23, 2021
Added a description of how to use `broken_wind_sensors` parameter.
minor edit
patrick-5546
suggested changes
Jan 15, 2022
Addresses feedback from @patrick-5546 to reword 'the chosen wind sensor' to convey that it is randomly selected not chosen.
patrick-5546
previously approved these changes
Jan 17, 2022
jamenkaye
commented
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.