Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 29, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 29, 2025 23:35
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 29, 2025
Copilot finished reviewing on behalf of Tyrrrz November 29, 2025 23:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polyfills for generic Enum methods (Parse<T>, GetNames<T>, and GetValues<T>) to provide compatibility with older .NET versions.

  • Implements Enum.Parse<T>(string) and Enum.Parse<T>(string, bool) for .NET Core 2.0
  • Implements Enum.GetNames<T>() and Enum.GetValues<T>() for .NET 5.0
  • Adds comprehensive test coverage for Parse methods and partial coverage for GetNames

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
PolyShim/Signatures.md Updates documentation with 4 new Enum methods and increments total counts accordingly
PolyShim/NetCore20/Enum.cs Implements generic Parse methods that delegate to non-generic Enum.Parse with typeof(T)
PolyShim/Net50/Enum.cs Implements generic GetNames and GetValues methods that delegate to non-generic versions
PolyShim.Tests/NetCore20/EnumTests.cs Adds comprehensive tests for Parse methods including error cases
PolyShim.Tests/Net50/EnumTests.cs Adds test for GetNames method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 51eae5d into master Nov 29, 2025
5 checks passed
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (8e70b97) to head (bf6bac9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #56   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants