Add polyfill for EqualityComparer<T>.Create(...)
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a polyfill for EqualityComparer<T>.Create(...) method introduced in .NET 8.0, allowing projects targeting older .NET versions to use this modern API.
- Implements
EqualityComparer<T>.Create()static method that accepts custom equality and hash code functions - Adds comprehensive test coverage for the new polyfill including edge cases
- Updates documentation to reflect the new signature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| PolyShim/Signatures.md | Updates signature counts and adds entry for EqualityComparer<T>.Create() |
| PolyShim/Net80/EqualityComparer.cs | Implements the polyfill using a private DelegateEqualityComparer<T> class with primary constructor syntax |
| PolyShim.Tests/Net80/EqualityComparerTests.cs | Adds test coverage for the Create method with and without hash code function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.