Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error trying to generate documentation #820

Closed
yarkovaleksei opened this issue Jul 21, 2018 · 13 comments
Closed

Error trying to generate documentation #820

yarkovaleksei opened this issue Jul 21, 2018 · 13 comments
Labels
bug Functionality does not match expectation help wanted Contributions are especially encouraged needs reproduction Needs a minimal reproducible case

Comments

@yarkovaleksei
Copy link

`$ typedoc --out ./docs ./src

Using TypeScript 2.7.2 from /home/user/.nvm/versions/node/v9.8.0/lib/node_modules/typedoc/node_modules/typescript/lib
Error: /home/user/git/frontend/node_modules/@types/sinon/index.d.ts(488)
';' expected.
`

@taoqf
Copy link

taoqf commented Jul 30, 2018

same issue

@connorjclark
Copy link

same

@connorjclark
Copy link

Seems the default behavior of ignoring these files is broken (seems it is meant to be opt in given --includeDeclarations exists).

@liuxh0
Copy link

liuxh0 commented Aug 16, 2018

+1

1 similar comment
@ali-habibzadeh
Copy link

+1

@aciccarello aciccarello added bug Functionality does not match expectation help wanted Contributions are especially encouraged Priority: 1 labels Aug 23, 2018
@dannycodes
Copy link

Is this still an issue for people? How did you work around it? AFAIK this bug breaks this library completely (100% unusable).

Am I missing something? I haven't found a workaround / solution after googling around.

@aciccarello aciccarello added the needs reproduction Needs a minimal reproducible case label Jan 11, 2019
@aciccarello
Copy link
Collaborator

By default typedoc includes declarations so any declaration files need to be compiled correctly. Could someone provide a repo which demonstrates this bug?

@daniellacosse
Copy link

daniellacosse commented Feb 14, 2019

+1 for me still, sinon - try running on https://github.com/daniellacosse/process-automation-scripts

tried commenting out the file that imported sinon, same issue. it wasn't until I uninstalled @types/sinon that it started working again. tried turning includeDeclarations off as well

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 16, 2019

Thanks for the repro to look at.

I haven't cloned to check it out, but I did notice that you are using ^0.11.1, if you update to ^0.14.2 you may find that the types work.

@daniellacosse
Copy link

oh shooot sorry thanks

@Gerrit0
Copy link
Collaborator

Gerrit0 commented May 11, 2019

Closing this since as far as I can tell the error was caused by a TypeScript version incompatibility. As TypeDoc (master at least) is now on 3.4, this should not longer be an issue.

In July 2018 TypeDoc was on TypeScript version 2.7.2. The Sinon types at that time required conditional types, which were introduced in 2.8 git blame

@Kalanamith
Copy link

This issue still exists in 2021, no document generation with TypeDoc if there is sinon .
Super helpful if someone can give a hand or two, Thank you so much

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 26, 2021

Please open a new issue rather than responding to one that's been closed for 2+ years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation help wanted Contributions are especially encouraged needs reproduction Needs a minimal reproducible case
Projects
None yet
Development

No branches or pull requests

10 participants