Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move under TypeStrong #47

Closed
basarat opened this issue Sep 23, 2015 · 8 comments
Closed

Move under TypeStrong #47

basarat opened this issue Sep 23, 2015 · 8 comments

Comments

@basarat
Copy link
Member

basarat commented Sep 23, 2015

Would you be willing to move this under TypeStrong. That would:

a) help ensure continued support
b.) make more defacto (not that it isn't the case right now).

I'd be happy to add you as an owner under the org

@jbrantly
Copy link
Member

Yea I'm open to this. I've sent you a twitter PM with my email to discuss.

@basarat
Copy link
Member Author

basarat commented Sep 23, 2015

Awesome. Thanks 🌹

@basarat basarat closed this as completed Sep 23, 2015
@blakeembrey
Copy link
Member

@basarat Haha, thanks for this 😄

@jbrantly I want to deprecate my loader in favour of pushing for a common one, do you mind if we start doing some PRs and fix some of the issues (if there are any still) on this loader? For reference, my loader is https://github.com/blakeembrey/typescript-simple-loader and I'm curious on the different implementation decisions.

Also related, but I'd love to bring all the different options in sync - should I create a meta repo for those discussions? Just things like compiler, project, etc.

@jbrantly
Copy link
Member

do you mind if we start doing some PRs and fix some of the issues (if there are any still) on this loader

Absolutely! I'd love collaboration. I've kept an on-going private list of bugs/features. I'm only aware of two bugs right at the moment: #45 and another regarding error reporting that I've created a test case for but haven't published/fixed yet. I'll see about surfacing those items via issues.

I'll also stop directly committing code and instead create PRs and ping you @blakeembrey for review.

Regarding other discussions, I'm good with a meta repo so we can get on the same page.

@johnnyreilly
Copy link
Member

This is brilliant!

@jbrantly
Copy link
Member

@blakeembrey FYI, I've transferred all of my outstanding work to PRs/issues

@blakeembrey
Copy link
Member

@jbrantly Awesome, cheers! Did you want to chat some time about the different approaches we took on the loaders? I'm curious, actually, about how you ended up with the resolver stuff. I can't really comment on whether there's too many issues/differences between them without doing a bunch more testing, but if we can add the ignoreWarnings option I could finally deprecate mine for this 😄

@jbrantly
Copy link
Member

@blakeembrey Yea definitely let's chat. Perhaps in the gitter room? I've started idling there.

Re: ignoreWarnings I opened #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants