Changes required due to TextBuffer.save becoming async in Atom 1.19

[maxbrunsfeld]

Hi! Thanks for maintaining the atom-typescript package!

In Atom v1.19, we will release a major change to Atom's core text buffer data structure. As part of this change, we have made TextBuffer.save asynchronous; rather than blocking until the save is complete, it now immediately returns a Promise that resolves when the save is complete. Because of this, a few other Atom APIs that use save have similarly become async:

• Pane.close
• TextBuffer.save
• TextEditor.save
• Pane.saveItem
• Pane.saveItemAs
• Pane.saveActiveItem
• Pane.saveActiveItemAs
• Pane.saveItems
• Workspace.saveActivePaneItem
• Workspace.saveActivePaneItemAs

Effects on this package

We think this package could be impacted by this upgrade because it calls the changed methods in the following places:

• TextBuffer.save
  • here
  • here

We found these calls using a regex search, so this list might be incomplete, and it might contain some false positives.

What to do about the change

It should be pretty easy to adjust your package code and/or tests to work with the new async behavior, and to simultaneously keep it working with older versions of Atom. Here are some examples of pull requests we opened on our bundled packages to cope with the change:

• Adjust test to work when TextBuffer.save is made async atom/autocomplete-plus#852
• Don't assume that save is synchronous in specs atom/whitespace#155
• Update package in preparation for native text buffer atom/line-ending-selector#45
• Wait for save to complete in tests atom/symbols-view#222
• Wait for save to complete in buffer modifier indicator test atom/status-bar#193
• Tweak tests so that they work when Pane.close becomes async atom/tabs#448

[pablomayobre]

Luckily this package doesn't seem affected by this issue, since it doesn't rely on TextBuffer.save being synchronous and instead waits for TextBuffer.onDidSave

[opavader]

@positive07 have you tried it with it beta1, atleast the autocomplete on type is not working.

[pablomayobre]

I don't see any link between autocomplete and this issue.

If this issue were to affect anything it would be the rename-refactor command

[github-actions]

This issue has been marked as stale because it did not have any activity for the last 90 days or more. Remove the stale label or comment or this will be closed in 14 days