Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: upgrade to version 1.0.1 of redactor #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix: upgrade to version 1.0.1 of redactor #57

wants to merge 1 commit into from

Conversation

thinkrapido
Copy link

  • pull request takes into account redactor change of callback handling
  • semicolon added due to jshint warning

@GAnatoliy
Copy link

Hi, looks that part that prevent collisions with change callback also should be updated.
Code example:

  angular.merge(options, redactorOptions, additionalOptions);

  // prevent collision with the constant values on ChangeCallback
  var changeCallback = (additionalOptions.callbacks && additionalOptions.callbacks.change) ||
    (redactorOptions.callbacks && redactorOptions.callbacks.change);
  if (changeCallback) {
    options.callbacks.change = function(value) {
      updateModel.call(this, value);
      changeCallback.call(this, value);
    };
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants