Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remainders other than buckets get voided #568

Closed
JaisDK opened this issue Jan 23, 2022 · 2 comments
Closed

Remainders other than buckets get voided #568

JaisDK opened this issue Jan 23, 2022 · 2 comments
Labels
Bug Something isn't working as expected wontfix This issue won't be solved because it is invalid or deemed out of scope

Comments

@JaisDK
Copy link

JaisDK commented Jan 23, 2022

https://github.com/ModdingForBlockheads/CookingForBlockheads/blob/1.18.x/shared/src/main/java/net/blay09/mods/cookingforblockheads/registry/CookingRegistry.java#L355

I don't know why you've chosen to only support buckets as remaining item from a crafting operation, other ingredients or containers can also have a remainder. With this check you're voiding those items.

@BlayTheNinth BlayTheNinth added 1.18 Bug Something isn't working as expected labels Feb 5, 2022
@BlayTheNinth BlayTheNinth moved this to 📑 Planning in Issues Sep 25, 2022
@BlayTheNinth BlayTheNinth moved this from 📝 Planning to 🎯 Ready for Development in Issues Sep 13, 2023
@BlayTheNinth BlayTheNinth added help wanted Pull Requests for this issue are encouraged and removed mc:1.18 labels Dec 6, 2023
@BlayTheNinth BlayTheNinth changed the title Add support for other container items than just buckets. Remainders other than buckets get voided Dec 6, 2023
@BlayTheNinth
Copy link
Member

Honestly, I don't remember why I limited it to buckets either. I found this diagram called theproblem.png from 2016 and I'm sure it made a lot of sense back then.

theproblem

(I believe buckets needed extra special support because the sink can provide water to recipes in the form of water buckets and would have resulted in infinite buckets - so remainder items worked at some point - not sure when they stopped working)

Blocked by #673 because the API rewrite will touch and resolve this as well

@BlayTheNinth BlayTheNinth added Blocked by Another Issue This issue is blocked by another issue and removed help wanted Pull Requests for this issue are encouraged labels Dec 6, 2023
@BlayTheNinth BlayTheNinth moved this from 🎯 Ready for Development to 📧 On Hold in Issues Dec 6, 2023
@BlayTheNinth BlayTheNinth added wontfix This issue won't be solved because it is invalid or deemed out of scope and removed Blocked by Another Issue This issue is blocked by another issue labels Dec 7, 2023
@BlayTheNinth
Copy link
Member

Actually testing with honey bottles => honey blocks right now and can't reproduce this. I'm receiving empty bottles just fine. In fact, the code linked originally was specifically code for avoiding duplicate buckets because the mod would return remainder items. I don't think there was any issue here in the first place.

@BlayTheNinth BlayTheNinth closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@github-project-automation github-project-automation bot moved this from 📧 On Hold to 🎉 Done in Issues Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as expected wontfix This issue won't be solved because it is invalid or deemed out of scope
Projects
Archived in project
Development

No branches or pull requests

2 participants