Skip to content

Support custom fluid to item mappings, e.g. goat milk to goat cheese #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Graywaren opened this issue Apr 15, 2019 · 8 comments
Closed
Labels
Feature New features or improvements to existing features Mod Compatibility Issues related to compatibility with another mod

Comments

@Graywaren
Copy link

I'm really loving CFB and especially it's ability to work with storage drawers and mod ingredients. However, it seems that mod milks won't be accepted into the milk jar. I can't find a config for this and while there is a compatibility config folder, I can't find any documentation on how to write something for it. (I did find someone who'd written compatibility for mod ingredients that now just work automatically, but I can't find info on how to use it in general... maybe I missed it.) I'd really like to attach the milk jar via pipes etc. to my dairy farm that provides different milks for different items (animania for example). Is there any way to do this? If not, would love to see this compatibility added.

@BlayTheNinth
Copy link
Member

What mod is adding the milk fluid?

@Graywaren
Copy link
Author

Animania and better animals plus are the two I have. There’s about 7 types between them: 4 cow, one sheep, 2 goat, I think.

@BlayTheNinth
Copy link
Member

Currently, only non-specialized milk (as in that which would be equivalent to Vanilla's milk bucket) is supported. I may be opening this up for better compatibility in the port to Minecraft 1.13, right now it'd require too many changes to existing compat files.

@BlayTheNinth BlayTheNinth added 1.13 Mod Compatibility Issues related to compatibility with another mod and removed information needed labels Apr 16, 2019
@Graywaren
Copy link
Author

Understandable. Would it be possible/easier to make the multiblock structure compatible with fluid tanks? Such as the tank from Open Blocks.. the way that storage drawers work. That way I could put milk tanks into the structure itself rather than going through the milk jar. CFB already recognizes when I have a bucket of those mod's milk in my inventory, so maybe there would be a way it could pull the milk from a tank inventory? Not sure if that's easier to implement than the milk jar though, but it would be super convenient for large quantities of milk from an automated farm.

@BlayTheNinth
Copy link
Member

That would not help in this case since the part that's needed isn't the fluid storage, but rather the mapping of fluids to their item counterparts. Additionally merging other fluid tanks into the multiblock is a different story, and while I may create a compat entrypoint for it, I don't think I'll add any official integrations, since people have already been running into performance problems with just the Storage Drawers integration.

@BlayTheNinth
Copy link
Member

What are these other milks used for? I saw Goat Cheese. Is there anything else? Thinking it might be easier after all to just allow a simple connect-tank-to-bucket compat than mess with the milk jar, especially if there's only such limited use for them.

@Graywaren
Copy link
Author

Hi! They're basically just used for various cheeses and equivalents to the vanilla milk. There's not much else they do that I know of.

@BlayTheNinth BlayTheNinth changed the title Mod Milks In Jar? Support custom fluid to item mappings, e.g. goat milk to goat cheese Sep 26, 2020
@BlayTheNinth BlayTheNinth added the help wanted Pull Requests for this issue are encouraged label Sep 26, 2020
@BlayTheNinth BlayTheNinth moved this to 📑 Planning in Issues Sep 25, 2022
@BlayTheNinth
Copy link
Member

Closing this since more extensible fluid support is planned for the new API via #673

@BlayTheNinth BlayTheNinth closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
@github-project-automation github-project-automation bot moved this from 📝 Planning to 🎉 Done in Issues Dec 6, 2023
@BlayTheNinth BlayTheNinth added Feature New features or improvements to existing features and removed help wanted Pull Requests for this issue are encouraged labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New features or improvements to existing features Mod Compatibility Issues related to compatibility with another mod
Projects
Archived in project
Development

No branches or pull requests

2 participants