Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for := #2409

Open
3 tasks
torfjelde opened this issue Nov 30, 2024 · 0 comments
Open
3 tasks

Better support for := #2409

torfjelde opened this issue Nov 30, 2024 · 0 comments
Milestone

Comments

@torfjelde
Copy link
Member

torfjelde commented Nov 30, 2024

There are a few things missing from the := to reach peak utility:

  • Tracked variables are only included in calls to sample => not currently used in returned or predict, i.e. it's non-trivial to extract := values using a chain.
  • := values are included in the chain returned from sample. However, it is treated as a standard parameter in the resulting chain! This means that it's not possible for downstream functionality, e.g. predict, to determine which parameters are actual parameters taht should go into, say, a VarInfo, and parameters that are from := expressions and thus should not go in, say, a VarInfo. Ref: Track := variables in resulting chains DynamicPPL.jl#693
  • Some things we'd like to track involve expensive computations that are unnecessary for inference. Hence we should ideally have a way to only activate this when we're not sampling. Ref: Convenience macros to use within @model DynamicPPL.jl#714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant