Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GHA macOS architecture to aarch64 #2395

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Change GHA macOS architecture to aarch64 #2395

merged 1 commit into from
Nov 27, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Nov 27, 2024

A few months ago (I think) GitHub updated their macos-latest runners to use Apple Silicon.

Since then, we've apparently been testing x64 Julia on an ARM runner which basically runs Julia via Rosetta emulation.

This PR fixes it.

cf. JuliaLang/www.julialang.org#2196 and JuliaLang/julia#55878

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (5b24ceb) to head (5a819ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2395   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          22       22           
  Lines        1575     1575           
=======================================
  Hits         1361     1361           
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Does this need to be changed in other repos too?

@penelopeysm
Copy link
Member Author

Indeed it does

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12051601116

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.585%

Totals Coverage Status
Change from base Build 11725449698: 0.0%
Covered Lines: 1233
Relevant Lines: 1569

💛 - Coveralls

@penelopeysm penelopeysm merged commit f4beee9 into master Nov 27, 2024
70 checks passed
@penelopeysm penelopeysm deleted the py/macos-arm branch November 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants