Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depreciate MCMC-interface code in favour of AbstractMCMC. #2281

Closed
yebai opened this issue Jul 9, 2024 · 1 comment
Closed

Depreciate MCMC-interface code in favour of AbstractMCMC. #2281

yebai opened this issue Jul 9, 2024 · 1 comment
Assignees
@sunxd3

Comments

@yebai
Copy link
Member

yebai commented Jul 9, 2024

The new external sampler interface demonstrated an excellent proof-of-concept for integrating Turing with MCMC samplers via AbstractMCMC without extra glue code. Let's push to get rid of the following files:

  • mcmc/sghmc.jl
  • mcmc/hmc.jl
  • mcmc/mh.jl
  • replace mcmc/gibbs.jl with experimental/gibbs.jl
@sunxd3 sunxd3 mentioned this issue Jul 12, 2024
Closed
@yebai
Copy link
Member Author

yebai commented Nov 11, 2024

Closed in favour of #2367.

@sunxd3, let's update existing PRs instead of opening new ones for similar tasks in the future. It is okay to open new issues if they are sufficiently different.

@yebai yebai closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunxd3 sunxd3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yebai @sunxd3