Improve loadstate implementation

Author: penelopeysm

src/mcmc/abstractmcmc.jl

@@ -136,7 +136,16 @@ function AbstractMCMC.sample(
     )
 end
 
-loadstate(c::MCMCChains.Chains) = c.info.samplerstate
+function loadstate(chain::MCMCChains.Chains)
+    if !haskey(chain.info, :samplerstate)
+        throw(
+            ArgumentError(
+                "the chain object does not contain the final state of the sampler; to save the final state you must sample with `save_state=true`",
+            ),
+        )
+    end
+    return chain.info[:samplerstate]
+end
 
 # TODO(penelopeysm): Remove initialstep and generalise MCMC sampling procedures
 function initialstep end

test/mcmc/hmc.jl

@@ -236,7 +236,7 @@ using Turing
             10;
             nadapts=0,
             discard_adapt=false,
-            initial_state=chn1.info.samplerstate,
+            initial_state=loadstate(chn1),
         )
         # if chn2 uses initial_state, its first sample should be somewhere around 5. if
         # initial_state isn't used, it will be sampled from [-2, 2] so this test should fail