-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health Check Service for Native Link #757
Comments
@DolceTriade the initial Please take a stab at it or we can discuss more on details for the external to internal mappings of what health could mean. |
Hm, I didn't know about the /status admin endpoint. That's probably sufficient for my use cases. we can probably close this unless the gRPC check is important. |
Yeah, when #643 is done, it should help discoverability. |
This should be resolved now with a few recently landed changes. Here's the last one on the config change: |
It would be nice if nativelink supported a basic health check for liveness checks in kubernetes/envoy/etc.
It seems Nativelink already has healthchecks for its stores. If we could propagate that into either a simple HTTP /healthz endpoint (maybe on the admin port?) or implement https://crates.io/crates/tonic-health on one of the gRPC ports, that would be ideal.
Can be configurable via services in the nativelink config.
Happy to take a stab at a PR if it seems like a desirable thing and we can agree on the mechanism.
The text was updated successfully, but these errors were encountered: