-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💎 Implement Google Cloud Bucket Store #659
Comments
IIRC when @allada and I talked about this a while ago we came to the conclusion that something like this might make sense:
One major hurdle I can currently see is that these stores can be tricky to test. Ideally we'll want some sort of short lived buckets for integration tests at some point. Technically I'd have a setup for CubeFS in an ad-hoc K8s cluster available, but while that might be useful for some API tests, that setup most likely can't mirror the actual behavior of AWS, GCP etc with respect to things like HTTP/HTTP2 and other not-so-obvious pitfalls. @steed924 Consider what i mentioned here as a sort of 'wishful thinking out loud' rather than requirements - the current S3 store is not exactly in optimal shape, so anything in this area will probably be better than the current implementation 😅 |
Thanks. I will keep in mind that. +@aaronmondal. |
FYI, while I was working on this issue, I encountered one problem while I was tryig to evaluate nativelink running with S3 bucket. Running the nativelink by But when I was going to evaluate the native link running by this command It raises an error while it tries to load the first chunk from ActionCache server, which is supported by S3 bucket. I hope to hear your opinions. @aaronmondal. Thanks. |
FYI, I've fixed the bug by myself. |
💎 $2,500 bounty • TraceMachinaSteps to solve:
Thank you for contributing to TraceMachina/nativelink! Add a bounty • Share on socials
|
/attempt #659
|
💡 @asr2003 submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
/attempt #659
|
We need to implement Google Cloud Bucket Store.
We can refer Amazon S3 Bucket Store code -
nativelink-store/src/s3_store.rs
as a reference which implements similar logic we are going to implement.Unit tests and example config files need to be added.
The text was updated successfully, but these errors were encountered: