Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker<->Scheduler communication should throw a warning if versions are mismatched #1253

Open
allada opened this issue Aug 8, 2024 · 1 comment · May be fixed by #1265
Open

Worker<->Scheduler communication should throw a warning if versions are mismatched #1253

allada opened this issue Aug 8, 2024 · 1 comment · May be fixed by #1265
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@allada
Copy link
Member

allada commented Aug 8, 2024

If a worker is connecting to the scheduler it both sides should express what version of nativelink they have in the metadata and validate that they match and if they don't throw a warning.

This will make it easier to see if any errors being thrown are related to an API change.
@allada allada added enhancement New feature or request good first issue Good for newcomers labels Aug 8, 2024
@aaronmondal aaronmondal changed the title Worker<->Scheduler communication should throw a warning if versions are missmatched Worker<->Scheduler communication should throw a warning if versions are mismatched Aug 8, 2024
@aleksdmladenovic
Copy link
Contributor

I will work on this issue. cc: @allada

@aleksdmladenovic aleksdmladenovic linked a pull request Sep 5, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@allada @aleksdmladenovic