-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about σ-fusion #13
Comments
Hi @Willyzw. How can you get that result when just running the code: python ./examples/slam_demo.py --dataset_dir=./datasets/Replica/office0 --dataset_name=nerf --buffer=100 --slam --parallel_run --img_stride=2 --fusion='sigma' --gui Could you please help me? Thanks in advance |
Hi @phamquandung, first you need to get it installed, I mostly get help from this PR #12. To run the evaluation, you will also need to add the flag In addition, I've committed my changes here, which may be useful afc1c2f |
Thanks for running the eval again @Willyzw!! I might have made a mistake. I can't re-run the eval right now, but, if you could share all the results you got, we can make sure we are getting similar values. |
Hi @ToniRV glad to receive your reply! You can please check my changes here master...Willyzw:NeRF-SLAM:master Besides notably the PSNR values are exactly the same as on paper. Yes, I also run the nerf fusion part. The results are almost consistent with the paper. An exception is the sequence Above are all my results. Cheers! |
Hi @Willyzw. Have you tried with NeRF? python ./examples/slam_demo.py --dataset_dir=./datasets/Replica/office0 --dataset_name=nerf --buffer=100 --slam --parallel_run --img_stride=2 --fusion='nerf' --eval. My result is all zero. I tried with with sigma but then it just stopped. |
Hi @phamquandung, yes I have tried both and have also encountered the mentioned problems. For nerf fusion, you need to skip the fitting step in the very beginning when missing images by checking For sigma fusion, I remember you need to disable the dataflow coming from the dataloader in slam_demo.py. |
Hi @Willyzw. Thanks for you quick response. You mean I need to check the line 74 in nerf_fusion.py as below figure? But then I meet other problem as shown below. |
Hi @Willyzw , Thanks a lot for your reply. |
Hi @phamquandung I didn't encounter your problem. Maybe you better try the sequential mode. |
I am also facing this issue. Would appreciate if you have any input @Willyzw. The variable Edit: After looking at your changes to the code here master...Willyzw:NeRF-SLAM:master and adding the two lines at row 287 where it says "# TODO: we need to restore the self.ref_frames[frame_id] = [image, gt, etc] for evaluation...." in nerf_fusion.py it now runs. Strange that this is not updated in the official code release yet. |
Hi, thanks for your great work, which also includes the implementation of sigma-fusion.
In the NeRF-SLAM paper, Table 1 shows a quite large difference in depth L1 metric between the TSDF-based methods (besides σ-fusion) and the nerf-based ones, which has surprised me a lot. So I just run the experiments and test this code myself. The Depth L1 results are as follows:
it turns out the TSDF-based approaches are indeed not as good as nerf-slam but actually not that much worse. I'm curious if this is related to any updates or bug fixes that have been made since then.
The text was updated successfully, but these errors were encountered: