From f06119309041b7c3fa2e519afffab284c50f80a7 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Fri, 6 Dec 2024 17:00:36 +0100 Subject: [PATCH] cs --- src/Collectors/Callable_/CallableTypeCollector.php | 2 -- src/Collectors/PublicClassLikeConstCollector.php | 2 +- src/Rules/UnusedPublicClassConstRule.php | 2 +- .../Fixture/plain-call-custom-function.php | 4 +++- .../Fixture/plain-call-custom-method.php | 7 +++++-- 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/Collectors/Callable_/CallableTypeCollector.php b/src/Collectors/Callable_/CallableTypeCollector.php index f714b13..e356af8 100644 --- a/src/Collectors/Callable_/CallableTypeCollector.php +++ b/src/Collectors/Callable_/CallableTypeCollector.php @@ -6,7 +6,6 @@ use PhpParser\Node; use PhpParser\Node\Expr; -use PhpParser\Node\Expr\FuncCall; use PHPStan\Analyser\Scope; use PHPStan\Collectors\Collector; use PHPStan\Reflection\ClassReflection; @@ -72,5 +71,4 @@ public function processNode(Node $node, Scope $scope): ?array return $classMethodReferences; } - } diff --git a/src/Collectors/PublicClassLikeConstCollector.php b/src/Collectors/PublicClassLikeConstCollector.php index 5ed6aa0..e37d884 100644 --- a/src/Collectors/PublicClassLikeConstCollector.php +++ b/src/Collectors/PublicClassLikeConstCollector.php @@ -56,7 +56,7 @@ public function processNode(Node $node, Scope $scope): ?array $constantNames[] = [$classReflection->getName(), $constConst->name->toString(), $node->getLine()]; } - if ([] === $constantNames) { + if ($constantNames === []) { return null; } diff --git a/src/Rules/UnusedPublicClassConstRule.php b/src/Rules/UnusedPublicClassConstRule.php index 42c2c62..d4350c1 100644 --- a/src/Rules/UnusedPublicClassConstRule.php +++ b/src/Rules/UnusedPublicClassConstRule.php @@ -70,7 +70,7 @@ public function processNode(Node $node, Scope $scope): array if ($declarationGroup === null) { continue; } - + foreach ($declarationGroup as [$className, $constantName, $line]) { if ($this->isClassConstantUsed( $className, diff --git a/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-function.php b/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-function.php index 691c12f..4da7f8f 100644 --- a/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-function.php +++ b/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-function.php @@ -10,4 +10,6 @@ myFunc([$caller1, 'callIt']); -function myFunc(callable $c) {} +function myFunc(callable $c) +{ +} diff --git a/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-method.php b/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-method.php index 1b2ddbd..92e28bd 100644 --- a/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-method.php +++ b/tests/Rules/UnusedPublicClassMethodRule/Fixture/plain-call-custom-method.php @@ -11,6 +11,9 @@ $c = new MyClass(); $c->myMethod([$caller1, 'callIt']); -class MyClass { - function myMethod(callable $c) {} +class MyClass +{ + public function myMethod(callable $c) + { + } }