Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow changing port of backend or frontend via envvar #30

Closed
stavros-k opened this issue Jul 28, 2022 · 2 comments · Fixed by TomBursch/kitchenowl-backend#9
Labels
enhancement New feature or request

Comments

@stavros-k
Copy link

What's the feature 🧐

Trying to wrap this project's container into a helm chart for TrueCharts catalog. (Native helm + TrueNAS scale catalog).

But having 2 containers with same port (80) into the same k8s pod is not possible.
While I can split back and front in to 2 different pods, this will impact the ease of use we try to provide for the users.

I propose to allow changing the port via env var as it will still work with the default (80) for current users, but still allow others to change.

Extra information and references

No response

@stavros-k stavros-k added the enhancement New feature or request label Jul 28, 2022
@TomBursch
Copy link
Owner

I'm not familiar with k8s pods, but it doesn't work even though port 80 on the backend doesn't need to be exposed? Can it not just listen there but nothing is routed to it? Either way I'll add such an environment variable, I guess it won't hurt.

@stavros-k
Copy link
Author

I'm not familiar with k8s pods, but it doesn't work even though port 80 on the backend doesn't need to be exposed? Can it not just listen there but nothing is routed to it? Either way I'll add such an environment variable, I guess it won't hurt.

It can't start at all, as it complains that the port is already in use.
All containers in the same pod share the same network namespace, and can't have the same port binded to more than one containers.

Variable should work!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants