Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packet ranges not very clearly explained #762

Closed
zoff99 opened this issue Feb 5, 2018 · 0 comments
Closed

packet ranges not very clearly explained #762

zoff99 opened this issue Feb 5, 2018 · 0 comments
Assignees
Labels
documentation Changes to the documentation P3 Low priority
Milestone

Comments

@zoff99
Copy link

zoff99 commented Feb 5, 2018

@iphydf can we add some comments here to make it more clear?

/* All packets starting with a byte in this range can be used for anything. */
#define PACKET_ID_LOSSLESS_RANGE_START 160
#define PACKET_ID_LOSSLESS_RANGE_SIZE 32
#define PACKET_LOSSY_AV_RESERVED 8 /* Number of lossy packet types at start of range reserved for A/V. */

LOSSLESS packets are 160-191
LOSSY packets are 192-??? (whats the max packet ID for this?)

but the first 8 packet ids are reserved for A/V:
192-199 --> reserved for A/V not useable by clients

c-toxcore/toxav/rtp.h

Lines 33 to 36 in fc0cc08

enum {
rtp_TypeAudio = 192,
rtp_TypeVideo,
};

rtp_TypeVideo should be hardcoded to 193 to make it clear (which we are about to do in the Video PRs)

@zoff99 zoff99 added the documentation Changes to the documentation label Feb 5, 2018
@iphydf iphydf added this to the v0.2.x milestone Jul 16, 2018
@zoff99 zoff99 closed this as completed Nov 4, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
@iphydf iphydf added the P3 Low priority label Feb 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to the documentation P3 Low priority
Projects
None yet
Development

No branches or pull requests

3 participants