function names misleading in ToxAV

[zoff99]

these 2 seem like the exact opposite functions:

rtp_send_data(RTPSession *session, const uint8_t *data, uint16_t length, Logger *log)

handle_rtp_packet(Messenger *m, uint32_t friendnumber, const uint8_t *data, uint32_t length, void *object)

they have the same input params const uint8_t *data, uint16_t length

rtp_send_data seems to send a full RTP Message, and on the receiver handle_rtp_packet packet would then get the exact RTP Message to handle it.
but thats not the case. there is actually no function that gets the full RTP Message on the receiver side.

handle_rtp_packet calls --> session->mcb
session->mcb() == vc_queue_message() // more confusing names
vc_queue_message() calls --> rb_write() // here you save parts of the RTP Message

vc_iterate() calls --> rb_read() // here you use parts of the RTP Message

and also the Packet ID byte gets silently stripped in handle_rtp_packet()
so if somebody in the future ever wants that information downstream
in vc_iterate() it is already lost.

these 2 things could be fixed to make it easier for people to understand and write new features

[zoff99]

now i think this comment is wrong:

c-toxcore/toxav/video.c

Lines 186 to 190 in 0fce3fc

	int vc_queue_message(void *vcp, struct RTPMessage *msg)
	{
	/* This function does the reconstruction of video packets.
	* See more info about video splitting in docs
	*/

but i am not sure. would be good to clarify and comment in the code if actually the full RTP Message is given to vc_queue_message()