Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toxcore removes message receipts and filetransfers from memory, when client has short network outage #548

Closed
zoff99 opened this issue May 16, 2017 · 2 comments
Assignees
Labels
enhancement New feature for the user, not a new feature for build script P3 Low priority
Milestone

Comments

@zoff99
Copy link

zoff99 commented May 16, 2017

when on a mobile phone you can be offline rather often (elevator, parking garage, bad cell service, tunnel ...) then you go offline and online again.
but now you will not receive message read notifications and you lose all FT numbers.
i don't think this is good

https://github.com/TokTok/c-toxcore/blob/master/toxcore/Messenger.c#L930

break_files(m, friendnumber);
clear_receipts(m, friendnumber);

what if we removed these 2 lines?
(or maybe add a timespan, only when offline for more than 5 minutes lose these values.)
keep the data in memory, like you were online the whole time.

comments?

@zoff99 zoff99 added the enhancement New feature for the user, not a new feature for build script label May 16, 2017
@iphydf
Copy link
Member

iphydf commented Jan 16, 2018

It's by design. @irungentoo for comments on this design decision.

@zoff99
Copy link
Author

zoff99 commented Jan 17, 2018

@iphydf for multidevice and offline messages we need:
peristent msg ids, msg sent date, persistent FT numbers

@iphydf iphydf added this to the v0.2.x milestone Jul 16, 2018
@zoff99 zoff99 changed the title toxcore removes message receipts and filetransfers from memory, when client has short networt outage toxcore removes message receipts and filetransfers from memory, when client has short network outage Jul 30, 2018
@zoff99 zoff99 closed this as completed Nov 4, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
@iphydf iphydf added the P3 Low priority label Feb 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script P3 Low priority
Projects
None yet
Development

No branches or pull requests

4 participants