-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid bit rate prevents call #375
Comments
You're trying to start a call without audio or video... https://github.com/TokTok/c-toxcore/blob/master/toxav/toxav.h#L229 Can you describe a case in which anyone would need to do that? |
when you dont have audio. then a bitrate > 0 would in fact be wrong. and here also is (at least) a documentation bug: |
Right, you can start a toxav call, with audio and/or video. You can not start a toxav call with audio and/or/neither video. When would you want to start a toxav call without audio, and without video? |
https://github.com/TokTok/c-toxcore/blob/master/toxav/toxav.h#L229 nobody knows what valid bitrates are. there should be a TOXAV_BITRATE_AUDO_MINIMUM |
https://github.com/TokTok/c-toxcore/blob/master/toxav/toxav.c#L273
if i call toxav_call to initiate a call, and i do not specify a valid audio bit rate, then it will not even ring.
it will fail with TOXAV_ERR_CALL_INVALID_BIT_RATE
video bit rate checking is totally disabled: https://github.com/TokTok/c-toxcore/blob/master/toxav/toxav.c#L1016
is that ok? seems strange.
i think i should be able to make a call without audio (audio_bit_rate=0)
The text was updated successfully, but these errors were encountered: