Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap all libsodium functions we use in toxcore in crypto_core. #342

Closed
iphydf opened this issue Dec 19, 2016 · 1 comment
Closed

Wrap all libsodium functions we use in toxcore in crypto_core. #342

iphydf opened this issue Dec 19, 2016 · 1 comment
Assignees
@iphydf
Labels
P3 Low priority
Milestone
v0.1.2

Comments

@iphydf
Copy link
Member

iphydf commented Dec 19, 2016

Currently we use crypto_* functions from libsodium, and its #defines directly in various places. We should instead wrap all libsodium functions and expose names that make sense in the context we use them in. E.g. it's not obvious that scalarmult_base is a function for computing the public key from a secret key.
@iphydf iphydf modified the milestones: v0.1.5, v0.1.2 Dec 19, 2016
@iphydf iphydf self-assigned this Dec 20, 2016
@iphydf
Copy link
Member Author

iphydf commented Dec 23, 2016

Done in #343.

@iphydf iphydf closed this as completed Dec 23, 2016
@iphydf iphydf added the P3 Low priority label Feb 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iphydf iphydf

Labels
P3 Low priority
Projects
None yet
Milestone
v0.1.2
Development

No branches or pull requests
1 participant
@iphydf